Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Unified Diff: runtime/vm/object.cc

Issue 1308013002: Addressed review comments from previous CLs; adding more Symbols::FromConcat (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Using zone() when allocating Zone objects Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/object.cc
diff --git a/runtime/vm/object.cc b/runtime/vm/object.cc
index f59846deb74321e36777d443c89634c572baf535..1bc793bc78c98d06c0499615f27043a7378fa951 100644
--- a/runtime/vm/object.cc
+++ b/runtime/vm/object.cc
@@ -10033,8 +10033,7 @@ RawClass* Library::LookupCoreClass(const String& class_name) {
String& name = String::Handle(class_name.raw());
if (class_name.CharAt(0) == kPrivateIdentifierStart) {
// Private identifiers are mangled on a per library basis.
- name = String::Concat(name, String::Handle(core_lib.private_key()));
- name = Symbols::New(name);
+ name = Symbols::FromConcat(name, String::Handle(core_lib.private_key()));
}
return core_lib.LookupClass(name);
}
@@ -10047,8 +10046,7 @@ RawString* Library::PrivateName(const String& name) const {
// ASSERT(strchr(name, '@') == NULL);
String& str = String::Handle();
str = name.raw();
- str = String::Concat(str, String::Handle(this->private_key()));
- str = Symbols::New(str);
+ str = Symbols::FromConcat(str, String::Handle(this->private_key()));
return str.raw();
}
@@ -14951,8 +14949,7 @@ RawString* AbstractType::BuildName(NameVisibility name_visibility) const {
} else {
bound_name = String::New(Symbols::OptimizedOut());
}
- type_name = String::Concat(type_name, bound_name);
- return Symbols::New(type_name);
+ return Symbols::FromConcat(type_name, bound_name);
}
if (IsTypeParameter()) {
return TypeParameter::Cast(*this).name();

Powered by Google App Engine
This is Rietveld 408576698