Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 1308003003: Revert of [simd.js] Disable SIMD polyfill. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [simd.js] Disable SIMD polyfill. (patchset #2 id:20001 of https://codereview.chromium.org/1305923005/ ) Reason for revert: Breaks simdjs performance tests. See: https://paste.googleplex.com/5883927122149376 Original issue's description: > [simd.js] Disable SIMD polyfill. > > Disable the polyfill in simd.js tests as the functions for Phase 1 have been implemented. > > BUG=v8:4124 > LOG=N > > R=bbudge@chromium.org, bmeurer@chromium.org, littledan@chromium.org > > Committed: https://crrev.com/749ba3a13558cb018a2ec783e5dfb56d2f8528d8 > Cr-Commit-Position: refs/heads/master@{#30452} TBR=littledan@chromium.org,bmeurer@chromium.org,bradnelson@chromium.org,bbudge@chromium.org,gdeepti@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4124 Committed: https://crrev.com/d21d14404cf33955e1a2658b3d8cc09dd73bddde Cr-Commit-Position: refs/heads/master@{#30470}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M test/simdjs/SimdJs.json View 2 chunks +2 lines, -1 line 0 comments Download
M test/simdjs/generate.py View 1 chunk +1 line, -0 lines 0 comments Download
M test/simdjs/harness-adapt.js View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of [simd.js] Disable SIMD polyfill.
5 years, 3 months ago (2015-08-31 11:58:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1308003003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1308003003/1
5 years, 3 months ago (2015-08-31 11:59:01 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-31 11:59:12 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-31 11:59:28 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d21d14404cf33955e1a2658b3d8cc09dd73bddde
Cr-Commit-Position: refs/heads/master@{#30470}

Powered by Google App Engine
This is Rietveld 408576698