Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(467)

Unified Diff: runtime/vm/flow_graph_compiler_arm.cc

Issue 1307943008: Make default_parameter_values a ZoneGrowableArray instead of an array in new space (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Cleanup Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/flow_graph_compiler_arm.cc
diff --git a/runtime/vm/flow_graph_compiler_arm.cc b/runtime/vm/flow_graph_compiler_arm.cc
index 1c2c6bdd98d23339f5bcbcda2d029e99ffc0d2a5..b366e55eb4ea702203cf8750f702cb8e53046aa9 100644
--- a/runtime/vm/flow_graph_compiler_arm.cc
+++ b/runtime/vm/flow_graph_compiler_arm.cc
@@ -864,9 +864,8 @@ void FlowGraphCompiler::CopyParameters() {
__ b(&assign_optional_parameter);
__ Bind(&load_default_value);
// Load R5 with default argument.
- const Object& value = Object::ZoneHandle(
- zone(), parsed_function().default_parameter_values().At(
- param_pos - num_fixed_params));
+ const Instance& value =
+ parsed_function().DefaultParameterAt(param_pos - num_fixed_params);
__ LoadObject(R5, value);
__ Bind(&assign_optional_parameter);
// Assign R5 to fp[kFirstLocalSlotFromFp - param_pos].
@@ -900,8 +899,7 @@ void FlowGraphCompiler::CopyParameters() {
__ CompareImmediate(R9, param_pos);
__ b(&next_parameter, GT);
// Load R5 with default argument.
- const Object& value = Object::ZoneHandle(
- zone(), parsed_function().default_parameter_values().At(i));
+ const Object& value = parsed_function().DefaultParameterAt(i);
__ LoadObject(R5, value);
// Assign R5 to fp[kFirstLocalSlotFromFp - param_pos].
// We do not use the final allocation index of the variable here, i.e.

Powered by Google App Engine
This is Rietveld 408576698