Make default_parameter_values a ZoneGrowableArray instead of an array in new space

runtime/vm/code_generator_test.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #include "platform/assert.h"
 #include "vm/globals.h"
 #include "vm/ast.h"
 #include "vm/assembler.h"
@@ skipping 191 matching lines @@
   // Since this function has an optional parameter, its prologue will copy
   // incoming parameters to locals.
   SequenceNode* node_seq = test->node_sequence();
   const int num_fixed_params = 1;
   const int num_opt_params = 1;
   const int num_params = num_fixed_params + num_opt_params;
   LocalScope* local_scope = node_seq->scope();
   local_scope->InsertParameterAt(0, NewTestLocalVariable("a"));
   local_scope->InsertParameterAt(1, NewTestLocalVariable("b"));
   ASSERT(local_scope->num_variables() == num_params);
-  const Array& default_values = Array::ZoneHandle(Array::New(num_opt_params));
-  default_values.SetAt(0, Smi::ZoneHandle(Smi::New(1)));  // b = 1.
+  ZoneGrowableArray<const Instance*>* default_values =
+      new ZoneGrowableArray<const Instance*>(num_opt_params);
+  default_values->Add(&Smi::ZoneHandle(Smi::New(1)));  // b = 1.
   test->set_default_parameter_values(default_values);
   const Function& function = test->function();
   function.set_is_native(true);
   function.set_num_fixed_parameters(num_fixed_params);
   function.SetNumOptionalParameters(num_opt_params, true);
   const String& native_name =
       String::ZoneHandle(Symbols::New("TestSmiSub"));
   NativeFunction native_function =
       reinterpret_cast<NativeFunction>(TestSmiSub);
   node_seq->Add(
@@ skipping 152 matching lines @@
   const int num_fixed_params = 2;
   const int num_opt_params = 3;
   const int num_params = num_fixed_params + num_opt_params;
   LocalScope* local_scope = node_seq->scope();
   local_scope->InsertParameterAt(0, NewTestLocalVariable("a"));
   local_scope->InsertParameterAt(1, NewTestLocalVariable("b"));
   local_scope->InsertParameterAt(2, NewTestLocalVariable("c"));
   local_scope->InsertParameterAt(3, NewTestLocalVariable("d"));
   local_scope->InsertParameterAt(4, NewTestLocalVariable("e"));
   ASSERT(local_scope->num_variables() == num_params);
-  const Array& default_values = Array::ZoneHandle(Array::New(num_opt_params));
-  default_values.SetAt(0, Smi::ZoneHandle(Smi::New(10)));
-  default_values.SetAt(1, Smi::ZoneHandle(Smi::New(21)));
-  default_values.SetAt(2, Smi::ZoneHandle(Smi::New(-32)));
+  ZoneGrowableArray<const Instance*>* default_values =
+      new ZoneGrowableArray<const Instance*>(num_opt_params);
+  default_values->Add(&Smi::ZoneHandle(Smi::New(10)));
+  default_values->Add(&Smi::ZoneHandle(Smi::New(21)));
+  default_values->Add(&Smi::ZoneHandle(Smi::New(-32)));
   test->set_default_parameter_values(default_values);
   const Function& function = test->function();
   function.set_is_native(true);
   function.set_num_fixed_parameters(num_fixed_params);
   function.SetNumOptionalParameters(num_opt_params, true);
   function.set_parameter_types(Array::Handle(Array::New(num_params)));
   function.set_parameter_names(Array::Handle(Array::New(num_params)));
   const Type& param_type = Type::Handle(Type::DynamicType());
   for (int i = 0; i < num_params; i++) {
     function.SetParameterTypeAt(i, param_type);
@@ skipping 161 matching lines @@
   intptr_t num_libs = libs.Length();
   Library& app_lib = Library::Handle();
   app_lib ^= libs.At(num_libs - 1);
   ASSERT(!app_lib.IsNull());
   const Class& cls = Class::Handle(
       app_lib.LookupClass(String::Handle(Symbols::New("A"))));
   EXPECT_EQ(cls.raw(), result.clazz());
 }
 
 }  // namespace dart