Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Issue 1307883004: Use C OpenGL interface in mojo::GLContext (Closed)

Created:
5 years, 4 months ago by jamesr
Modified:
5 years, 4 months ago
Reviewers:
viettrungluu
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Use C OpenGL interface in mojo::GLContext This uses C entry points in mojo::GLContext, used by ganesh_app and keyboard_native, thus removing the last user of the C++ GL context. I will remove the SDK entry point for downcast in a follow up once all downstream consumers have stopped using it. This patch also up the CHROMIUM_map_sub bindings and fixes up the EXT_debug_marker bindings. R=viettrungluu@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/fe8fa530e5b9e36adbf3648f9411e59ac26d1e13

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -184 lines) Patch
M gpu/command_buffer/build_gles2_cmd_buffer.py View 7 chunks +24 lines, -26 lines 0 comments Download
M mojo/gles2/gles2_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/gpu/gl_context.h View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/gpu/gl_context.cc View 3 chunks +6 lines, -2 lines 1 comment Download
M mojo/gpu/mojo_gles2_impl_autogen.cc View 3 chunks +21 lines, -12 lines 0 comments Download
M mojo/public/c/gles2/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
A + mojo/public/c/gles2/chromium_map_sub.h View 2 chunks +4 lines, -4 lines 0 comments Download
D mojo/public/c/gles2/chromium_sub_image.h View 1 chunk +0 lines, -30 lines 0 comments Download
A + mojo/public/c/gles2/gles2_call_visitor_chromium_map_sub_autogen.h View 1 chunk +5 lines, -0 lines 0 comments Download
D mojo/public/c/gles2/gles2_call_visitor_chromium_sub_image_autogen.h View 1 chunk +0 lines, -24 lines 0 comments Download
M mojo/public/platform/native/BUILD.gn View 1 chunk +2 lines, -2 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_map_sub_thunks.h View 1 chunk +44 lines, -0 lines 0 comments Download
A mojo/public/platform/native/gles2_impl_chromium_map_sub_thunks.cc View 1 chunk +31 lines, -0 lines 0 comments Download
D mojo/public/platform/native/gles2_impl_chromium_sub_image_thunks.h View 1 chunk +0 lines, -44 lines 0 comments Download
D mojo/public/platform/native/gles2_impl_chromium_sub_image_thunks.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M shell/native_application_support.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
jamesr
Also we need to start autogenerating these thunks files, they're 100% mechanical except for typos ...
5 years, 4 months ago (2015-08-24 17:42:36 UTC) #2
viettrungluu
LGTM w/(optional) nit. (Ideally, you'd have green-ish trybots too, but you break it you buy ...
5 years, 4 months ago (2015-08-24 17:51:06 UTC) #3
jamesr
On 2015/08/24 at 17:51:06, viettrungluu wrote: > LGTM w/(optional) nit. (Ideally, you'd have green-ish trybots ...
5 years, 4 months ago (2015-08-24 17:57:27 UTC) #4
jamesr
On 2015/08/24 at 17:51:06, viettrungluu wrote: > LGTM w/(optional) nit. (Ideally, you'd have green-ish trybots ...
5 years, 4 months ago (2015-08-24 18:08:19 UTC) #5
jamesr
5 years, 4 months ago (2015-08-24 18:10:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
fe8fa530e5b9e36adbf3648f9411e59ac26d1e13 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698