Issue 1307863010: Mac Overlays: Enable h264 overlays

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1307863010: Mac Overlays: Enable h264 overlays (Closed)

Created:
5 years, 3 months ago by ccameron

Modified:
5 years, 3 months ago

Reviewers:

CC:
chromium-reviews, posciak+watch_chromium.org, jam, mcasas+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, wjia+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@2490

Target Ref:
refs/pending/branch-heads/2490

Project:
chromium

Visibility:
Public.

More Reviews

Description

Mac Overlays: Enable h264 overlays Punch a hole from GpuVideoDecodeAccelerator to VTVideoDecodeAccelerator via a callback to BindImage, following the model found in VaapiVideoDecodeAccelerator. If successful, set allow_overlay on the frame's resource. BUG=527650 Review URL: https://codereview.chromium.org/1320893004 Cr-Commit-Position: refs/heads/master@{#347546} (cherry picked from commit 7ed442bbaf3a5038ce6b9d712200557a0854f888) Committed: https://chromium.googlesource.com/chromium/src/+/3ffaac7291241cb501afa8996c9a5fb3cfbff842

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+90 lines, -23 lines)			Patch
M	content/browser/compositor/gpu_process_transport_factory.cc	View	1 chunk	+8 lines, -6 lines	0 comments	Download
M	content/common/gpu/media/gpu_video_decode_accelerator.cc	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/common/gpu/media/vt_video_decode_accelerator.h	View	6 chunks	+28 lines, -6 lines	0 comments	Download
M	content/common/gpu/media/vt_video_decode_accelerator.cc	View	9 chunks	+51 lines, -10 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

ccameron

5 years, 3 months ago (2015-09-09 19:00:58 UTC) #1

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
3ffaac7291241cb501afa8996c9a5fb3cfbff842.

Expand Messages | Collapse Messages