Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 1307863007: Revert of [arm] Decrease the size of the assembler class by allocating buffers of pending constants on the he… (Closed)

Created:
5 years, 3 months ago by Igor Sheludko
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [arm] Decrease the size of the assembler class by allocating buffers of pending constants on the he… (patchset #2 id:20001 of https://codereview.chromium.org/1309903009/ ) Reason for revert: Static assert failed on ARM64 Original issue's description: > [arm] Decrease the size of the assembler class by allocating buffers of pending constants on the heap. > > BUG=chromium:521828 > LOG=N > > Committed: https://crrev.com/033af3fa511c52bc4049cd278d0623a6c6f9f9c3 > Cr-Commit-Position: refs/heads/master@{#30592} TBR=jkummerow@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:521828 Committed: https://crrev.com/5849a1ac379728f26f0be5226162eb9fbf6a86ba Cr-Commit-Position: refs/heads/master@{#30593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M src/arm/assembler-arm.h View 2 chunks +2 lines, -5 lines 0 comments Download
M src/arm/assembler-arm.cc View 4 chunks +0 lines, -26 lines 0 comments Download
M src/ic/access-compiler.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Igor Sheludko
5 years, 3 months ago (2015-09-04 16:09:42 UTC) #1
Created Revert of [arm] Decrease the size of the assembler class by allocating
buffers of pending constants on the he…

Powered by Google App Engine
This is Rietveld 408576698