components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java - Issue 1307863006: [Cronet] Change interface APIs to abstract classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java

Issue 1307863006: [Cronet] Change interface APIs to abstract classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Helen's comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/README.md ('K') | « components/cronet/android/test/javatests/src/org/chromium/net/TestDataProvider.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/TestUrlRequestListener.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java b/components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java

index eff5acf812dd8416945c33c3d996b232c42a6567..59b288c01c66f00f4f930be9c3b4f288b400eaa7 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/TestDrivenDataProvider.java

@@ -17,7 +17,7 @@ import java.util.concurrent.Executor;

* Chunked mode is not supported here, since the main interest is to test

* different order of init/read/rewind calls.

-class TestDrivenDataProvider implements UploadDataProvider {

+class TestDrivenDataProvider extends UploadDataProvider {

private final Executor mExecutor;

private final List<byte[]> mReads;

private final ConditionVariable mWaitForReadRequest =