components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java - Issue 1307863006: [Cronet] Change interface APIs to abstract classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

Issue 1307863006: [Cronet] Change interface APIs to abstract classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address Helen's comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/README.md ('K') | « components/cronet/android/java/src/org/chromium/net/urlconnection/CronetOutputStream.java ('k') | components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

index a78537720a6788a39dace20ed03234ab746b33c8..0b6fde2b7b745e151e4079a2200e9128ab6d945a 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/CronetUrlRequestTest.java

@@ -1358,7 +1358,7 @@ public class CronetUrlRequestTest extends CronetTestBase {

@SmallTest

@Feature({"Cronet"})

public void testUploadExecutorShutdown() throws Exception {

- class HangingUploadDataProvider implements UploadDataProvider {

+ class HangingUploadDataProvider extends UploadDataProvider {

UploadDataSink mUploadDataSink;

ByteBuffer mByteBuffer;

ConditionVariable mReadCalled = new ConditionVariable(false);