Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: components/cronet/README.md

Issue 1307863006: [Cronet] Change interface APIs to abstract classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/README.md
diff --git a/components/cronet/README.md b/components/cronet/README.md
index 22aca16a4a4363afc2a88044b36175365beaa327..87e6aec79ea80352af3b052ce8c1cc1a2c99377c 100644
--- a/components/cronet/README.md
+++ b/components/cronet/README.md
@@ -8,10 +8,10 @@ API as well as support for the [java.net.HttpURLConnection] API.
This document gives a brief introduction to using these two Java APIs.
### Basics
-First you will need to implement the `UrlRequestListener` interface to handle
+First you will need to implement the `UrlRequestListener` class to handle
xunjieli 2015/09/03 04:32:02 I am not sure... Should we also use "extend" inste
pauljensen 2015/09/11 15:20:41 Ya, I think we should stick with "implement" in En
xunjieli 2015/09/11 16:26:35 Acknowledged. SGTM
events during the lifetime of a request. For example:
- class MyListener implements UrlRequestListener {
+ class MyListener extends UrlRequestListener {
@Override
public void onReceivedRedirect(UrlRequest request,
ResponseInfo responseInfo, String newLocationUrl) {
@@ -78,7 +78,7 @@ Make a request like this:
request.start();
In the above example, `MyListener` implements the `UrlRequestListener`
xunjieli 2015/09/03 04:32:02 Here, I also wonder whether we should s/implements
pauljensen 2015/09/11 15:20:41 I feel the same way as on line 11. I reworded lik
-interface. The request is started asynchronously. When the response is ready
+class. The request is started asynchronously. When the response is ready
(fully or partially), and in the event of failures or redirects,
`listener`'s methods will be invoked on `executor`'s thread to inform the
client of the request state and/or response information.
@@ -104,7 +104,7 @@ which signals the completion of the request.
request.start();
In the above example, `MyUploadDataProvider` implements the
xunjieli 2015/09/03 04:32:02 And here.
pauljensen 2015/09/11 15:20:41 I feel the same way as on line 11. I reworded lik
-`UploadDataProvider` interface. When Cronet is ready to send the request body,
+`UploadDataProvider` class. When Cronet is ready to send the request body,
`myUploadDataProvider.read(UploadDataSink uploadDataSink,
ByteBuffer byteBuffer)` will be invoked. The client will need to write the
request body into `byteBuffer`. Once the client is done writing into

Powered by Google App Engine
This is Rietveld 408576698