[Cronet] Change interface APIs to abstract classes

components/cronet/android/java/src/org/chromium/net/urlconnection/CronetChunkedOutputStream.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.net.urlconnection;
 
+import org.chromium.net.UploadDataProvider;
 import org.chromium.net.UploadDataSink;
 
 import java.io.IOException;
 import java.net.HttpRetryException;
 import java.nio.ByteBuffer;
 
 /**
  * An implementation of {@link java.io.OutputStream} to send data to a server,
  * when {@link CronetHttpURLConnection#setChunkedStreamingMode} is used.
  * This implementation does not buffer the entire request body in memory.
  * It does not support rewind. Note that {@link #write} should only be called
  * from the thread on which the {@link #mConnection} is created.
  */
 final class CronetChunkedOutputStream extends CronetOutputStream {
     private final CronetHttpURLConnection mConnection;
     private final MessageLoop mMessageLoop;
     private final ByteBuffer mBuffer;
+    private final UploadDataProvider mUploadDataProvider = new UploadDataProviderImpl();
     private long mBytesWritten;
     private boolean mLastChunk = false;
     private boolean mClosed = false;
 
     /**
      * Package protected constructor.
      * @param connection The CronetHttpURLConnection object.
      * @param contentLength The content length of the request body. Non-zero for
      *            non-chunked upload.
      */
@@ skipping 66 matching lines @@
     void setConnected() throws IOException {
         // Do nothing.
     }
 
     @Override
     void checkReceivedEnoughContent() throws IOException {
         // Do nothing.
     }
 
     @Override
-    public long getLength() {
-        return -1;
+    public UploadDataProvider getUploadDataProvider() {

[xunjieli, 2015/09/03 04:32:02]

nit: can remove "public" modifier.

[pauljensen, 2015/09/11 15:20:41]

Done.

+        return mUploadDataProvider;
     }
 
-    @Override
-    public void read(final UploadDataSink uploadDataSink, final ByteBuffer byteBuffer) {
-        int availableSpace = byteBuffer.capacity() - byteBuffer.position();
-        if (availableSpace < mBuffer.position()) {
-            // byteBuffer does not have enough capacity, so only put a portion
-            // of mBuffer in it.
-            byteBuffer.put(mBuffer.array(), 0, availableSpace);
-            mBuffer.position(availableSpace);
-            // Move remaining buffer to the head of the buffer for use in the
-            // next read call.
-            mBuffer.compact();
-            uploadDataSink.onReadSucceeded(false);
-        } else {
-            // byteBuffer has enough capacity to hold the content of mBuffer.
-            mBuffer.flip();
-            byteBuffer.put(mBuffer);
-            // Reuse this buffer.
-            mBuffer.clear();
-            // Quit message loop so embedder can write more data.
-            mMessageLoop.quit();
-            uploadDataSink.onReadSucceeded(mLastChunk);
+    private class UploadDataProviderImpl extends UploadDataProvider {
+        @Override
+        public long getLength() {
+            return -1;
+        }
+
+        @Override
+        public void read(final UploadDataSink uploadDataSink, final ByteBuffer byteBuffer) {
+            int availableSpace = byteBuffer.capacity() - byteBuffer.position();
+            if (availableSpace < mBuffer.position()) {
+                // byteBuffer does not have enough capacity, so only put a portion
+                // of mBuffer in it.
+                byteBuffer.put(mBuffer.array(), 0, availableSpace);
+                mBuffer.position(availableSpace);
+                // Move remaining buffer to the head of the buffer for use in the
+                // next read call.
+                mBuffer.compact();
+                uploadDataSink.onReadSucceeded(false);
+            } else {
+                // byteBuffer has enough capacity to hold the content of mBuffer.
+                mBuffer.flip();
+                byteBuffer.put(mBuffer);
+                // Reuse this buffer.
+                mBuffer.clear();
+                // Quit message loop so embedder can write more data.
+                mMessageLoop.quit();
+                uploadDataSink.onReadSucceeded(mLastChunk);
+            }
+        }
+
+        @Override
+        public void rewind(UploadDataSink uploadDataSink) {
+            uploadDataSink.onRewindError(
+                    new HttpRetryException("Cannot retry streamed Http body", -1));
         }
     }
-
-    @Override
-    public void rewind(UploadDataSink uploadDataSink) {
-        uploadDataSink.onRewindError(new HttpRetryException("Cannot retry streamed Http body", -1));
-    }
 }