Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 1307863004: Revert of Browser tests for the ChromeOS chromecast system tray item. (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
achuithb, oshima, jdufault
CC:
chromium-reviews, kalyank, sadrul, extensions-reviews_chromium.org, chromium-apps-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lkgr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Browser tests for the ChromeOS chromecast system tray item. (patchset #3 id:60001 of https://codereview.chromium.org/1287023010/ ) Reason for revert: broke the compile on ChromeOS bots: FAILED: ... ../../chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:53:10: error: variable 'result' is uninitialized when used here [-Werror,-Wuninitialized] return result; ^~~~~~ ../../chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc:51:14: note: initialize the variable 'result' to silence this warning bool result; ^ = false Original issue's description: > Browser tests for the ChromeOS chromecast system tray item. > > This was initially reviewed in https://codereview.chromium.org/1231593002/. I've > moved this to a new CL since there have been a few implementation changes and as > a result this needs another look. > > BUG=497343, 514952 > > Committed: https://crrev.com/926097380c61018aa2d5dfc99299f592ccfa5738 > Cr-Commit-Position: refs/heads/master@{#344939} TBR=achuith@chromium.org,oshima@chromium.org,jdufault@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497343, 514952 Committed: https://crrev.com/aff2cdf3727ff6bd06c0e2193ab0c554f65ef1b6 Cr-Commit-Position: refs/heads/master@{#344946}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -292 lines) Patch
D chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc View 1 chunk +0 lines, -257 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/extensions/tray_cast/background.js View 2 chunks +43 lines, -31 lines 0 comments Download
M chrome/test/data/extensions/tray_cast/manifest.json View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Browser tests for the ChromeOS chromecast system tray item.
5 years, 4 months ago (2015-08-22 01:44:29 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307863004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307863004/1
5 years, 4 months ago (2015-08-22 01:44:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-22 01:45:38 UTC) #3
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 01:46:20 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aff2cdf3727ff6bd06c0e2193ab0c554f65ef1b6
Cr-Commit-Position: refs/heads/master@{#344946}

Powered by Google App Engine
This is Rietveld 408576698