Source/core/inspector/InspectorTracingAgent.h - Issue 1307863003: Add support for returning traces as streams in DevTools protocol

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/InspectorTracingAgent.h

Issue 1307863003: Add support for returning traces as streams in DevTools protocol (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/inspector-protocol/timeline/fetch-as-stream-expected.txt ('k') | Source/core/inspector/InspectorTracingAgent.cpp » ('j') | Source/devtools/protocol.json » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/InspectorTracingAgent.h

diff --git a/Source/core/inspector/InspectorTracingAgent.h b/Source/core/inspector/InspectorTracingAgent.h

index 5c98afe15a30e3a759363efa1ce0ced6a8e49c04..78c0a30b03289bc2f34ce09022857e5ed4191dbf 100644

--- a/Source/core/inspector/InspectorTracingAgent.h

+++ b/Source/core/inspector/InspectorTracingAgent.h

@@ -44,7 +44,7 @@ public:

// Protocol method implementations.

void start(ErrorString*, const String* categoryFilter, const String*, const double*, PassRefPtrWillBeRawPtr<StartCallback>) override;

- virtual void end(ErrorString*, PassRefPtrWillBeRawPtr<EndCallback>);

+ void end(ErrorString*, const bool*, PassRefPtrWillBeRawPtr<EndCallback>) override;

// Methods for other agents to use.

void setLayerTreeId(int);