Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(48)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307863003: Add support for returning traces as streams in DevTools protocol (Closed)

Created:
5 years, 4 months ago by caseq
Modified:
5 years ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add support for returning traces as streams in DevTools protocol Related chromium-side change: https://codereview.chromium.org/1307073002 BUG=456845 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201322

Patch Set 1 : #

Total comments: 1

Patch Set 2 : extracted test to a separate CL, moved IO from browser_protocol.json to protocol.json #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -6 lines) Patch
M Source/core/inspector/CodeGeneratorInspector.py View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/devtools/front_end/sdk/TracingManager.js View 1 2 chunks +6 lines, -1 line 0 comments Download
M Source/devtools/protocol.json View 1 3 chunks +41 lines, -1 line 0 comments Download

Messages

Total messages: 15 (9 generated)
caseq
5 years, 4 months ago (2015-08-22 00:14:16 UTC) #4
pfeldman
lgtm https://codereview.chromium.org/1307863003/diff/80001/Source/devtools/protocol.json File Source/devtools/protocol.json (right): https://codereview.chromium.org/1307863003/diff/80001/Source/devtools/protocol.json#newcode4821 Source/devtools/protocol.json:4821: { "name": "returnAsStream", "type": "boolean", "optional": true, "description": ...
5 years, 3 months ago (2015-08-24 17:51:15 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307863003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307863003/100001
5 years, 3 months ago (2015-08-27 01:14:55 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/61307)
5 years, 3 months ago (2015-08-27 02:36:01 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307863003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307863003/100001
5 years, 3 months ago (2015-08-27 15:55:10 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 17:06:40 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:100001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201322

Powered by Google App Engine
This is Rietveld 408576698