media/blink/skcanvas_video_renderer.cc - Issue 1307853003: Add support for converting I420 software frames into NV12 hardware frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/blink/skcanvas_video_renderer.cc

Issue 1307853003: Add support for converting I420 software frames into NV12 hardware frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@biplanar

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« cc/resources/video_resource_updater.cc ('K') | « media/base/video_frame.cc ('k') | media/renderers/mock_gpu_video_accelerator_factories.cc » ('j') | media/video/gpu_memory_buffer_video_frame_pool.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/blink/skcanvas_video_renderer.cc

diff --git a/media/blink/skcanvas_video_renderer.cc b/media/blink/skcanvas_video_renderer.cc

index bd628a5176eeec3f0992901cdc6442dd1c577a5d..f884f31eef66014ce22b066b4c82b11efb7525e7 100644

--- a/media/blink/skcanvas_video_renderer.cc

+++ b/media/blink/skcanvas_video_renderer.cc

@@ -133,6 +133,7 @@ skia::RefPtr<SkImage> NewSkImageFromVideoFrameNative(

VideoFrame* video_frame,

const Context3D& context_3d) {

DCHECK(PIXEL_FORMAT_ARGB == video_frame->format() ||

+ PIXEL_FORMAT_NV12 == video_frame->format() ||

PIXEL_FORMAT_UYVY == video_frame->format());

const gpu::MailboxHolder& mailbox_holder = video_frame->mailbox_holder(0);