Devtools UI: Maintain closed tooltips on click on Windows

Source/devtools/front_end/ui/Tooltip.js

 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @constructor
  * @param {!Document} doc
  */
 WebInspector.Tooltip = function(doc)
 {
     this.element = doc.body.createChild("div");
     this._shadowRoot = WebInspector.createShadowRootWithCoreStyles(this.element);
     this._shadowRoot.appendChild(WebInspector.Widget.createStyleElement("ui/tooltip.css"));
 
     this._tooltipElement = this._shadowRoot.createChild("div", "tooltip");
     doc.addEventListener("mousemove", this._mouseMove.bind(this), false);

[pfeldman, 2015/08/21 17:30:20]

I changed these to , true); in one of my previous changes to make sure you are
hiding on consumed click.

[samli, 2015/08/26 20:15:52]

Rebased.

-    doc.addEventListener("mousedown", this._hide.bind(this), false);
+    doc.addEventListener("mousedown", this._hide.bind(this, true), false);
 }
 
 WebInspector.Tooltip.Timing = {
     // Max time between tooltips showing that no opening delay is required.
     "InstantThreshold": 300,
     // Wait time before opening a tooltip.
     "OpeningDelay": 600
 }
 
 WebInspector.Tooltip.AlignmentOverride = {
@@ skipping 71 matching lines @@
         var tooltipHeight = this._tooltipElement.offsetHeight;
         var tooltipX = anchorBox.x;
         tooltipX = Number.constrain(tooltipX,
             containerOffset.x + pageMargin,
             containerOffset.x + containerOffsetWidth - tooltipWidth - pageMargin);
         var onBottom = anchorBox.y + anchorOffset + anchorBox.height < containerOffset.y + containerOffsetHeight;
         var tooltipY = onBottom ? anchorBox.y + anchorBox.height + anchorOffset : anchorBox.y - tooltipHeight - anchorOffset;
         this._tooltipElement.positionAt(tooltipX, tooltipY);
     },
 
-    _hide: function()
+    /**
+     * @param {boolean=} removeInstant
+     */
+    _hide: function(removeInstant)
     {
         delete this._anchorElement;
         this._tooltipElement.classList.remove("shown");
         if (Date.now() > this._tooltipLastOpened)
             this._tooltipLastClosed = Date.now();
+        if (removeInstant)
+            delete this._tooltipLastClosed;
     }
 }
 
 WebInspector.Tooltip._symbol = Symbol("Tooltip");
 
 /**
  * @param {!Document} doc
  */
 WebInspector.Tooltip.installHandler = function(doc)
 {
@@ skipping 27 matching lines @@
 
     /**
      * @param {!Element|string} x
      * @this {!Element}
      */
     set: function(x)
     {
         WebInspector.Tooltip.install(this, x);
     }
 });