Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307843002: Devtools UI: Maintain closed tooltips on click on Windows (Closed)

Created:
5 years, 4 months ago by samli
Modified:
5 years, 3 months ago
Reviewers:
pfeldman
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, yurys+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools UI: Maintain closed tooltips on click on Windows BUG=522796 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201266

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M Source/devtools/front_end/ui/Tooltip.js View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
samli
5 years, 4 months ago (2015-08-21 05:59:09 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307843002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307843002/1
5 years, 4 months ago (2015-08-21 06:00:28 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102203)
5 years, 4 months ago (2015-08-21 06:55:50 UTC) #6
pfeldman
https://codereview.chromium.org/1307843002/diff/1/Source/devtools/front_end/ui/Tooltip.js File Source/devtools/front_end/ui/Tooltip.js (right): https://codereview.chromium.org/1307843002/diff/1/Source/devtools/front_end/ui/Tooltip.js#newcode16 Source/devtools/front_end/ui/Tooltip.js:16: doc.addEventListener("mousemove", this._mouseMove.bind(this), false); I changed these to , true); ...
5 years, 4 months ago (2015-08-21 17:30:20 UTC) #7
samli
PTAL https://codereview.chromium.org/1307843002/diff/1/Source/devtools/front_end/ui/Tooltip.js File Source/devtools/front_end/ui/Tooltip.js (right): https://codereview.chromium.org/1307843002/diff/1/Source/devtools/front_end/ui/Tooltip.js#newcode16 Source/devtools/front_end/ui/Tooltip.js:16: doc.addEventListener("mousemove", this._mouseMove.bind(this), false); On 2015/08/21 at 17:30:20, pfeldman ...
5 years, 3 months ago (2015-08-26 20:15:53 UTC) #8
pfeldman
lgtm
5 years, 3 months ago (2015-08-26 20:58:05 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307843002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307843002/20001
5 years, 3 months ago (2015-08-26 21:01:12 UTC) #11
commit-bot: I haz the power
5 years, 3 months ago (2015-08-27 00:18:32 UTC) #12
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201266

Powered by Google App Engine
This is Rietveld 408576698