Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307833003: Make the skipWaiting checkbox in Service Workers view unchecked by default (Closed)

Created:
5 years, 4 months ago by horo
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org, serviceworker-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Make the skipWaiting checkbox in Service Workers view unchecked by default It is weird that the SW update behavior changes when devtools open. BUG=466871 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201037

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M Source/devtools/front_end/resources/ServiceWorkersView.js View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
horo
Could you please review this?
5 years, 4 months ago (2015-08-21 06:49:02 UTC) #2
pfeldman
lgtm
5 years, 4 months ago (2015-08-21 18:24:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307833003/1
5 years, 4 months ago (2015-08-21 22:36:10 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/102662)
5 years, 4 months ago (2015-08-22 00:08:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307833003/1
5 years, 4 months ago (2015-08-22 02:32:30 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 04:05:08 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201037

Powered by Google App Engine
This is Rietveld 408576698