Issue 130783004: Add support for font-weight: lighter for web fonts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130783004: Add support for font-weight: lighter for web fonts (Closed)

Created:
6 years, 11 months ago by eae

Modified:
6 years, 11 months ago

Reviewers:
dglazkov

CC:
blink-reviews, dglazkov+blink, apavlov+blink_chromium.org, darktears

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Add support for font-weight: lighter for web fonts Update FontFace::traitsMask to add the missing CSSValueLighter keyword thereby supporting font-weight: lighter. Also add ASSERT to ensure that all supported weights are handled. TEST=fast/css/webfont-lighter-weight-crash.html BUG=334684 R=dglazkov@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165245

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -0 lines)			Patch
A	LayoutTests/fast/css/webfont-lighter-weight-crash.html	View	1 chunk	+22 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/css/webfont-lighter-weight-crash-expected.txt	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/css/FontFace.cpp	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eae@chromium.org/130783004/1

6 years, 11 months ago (2014-01-16 18:42:31 UTC) #3

Message was sent while issue was closed.

Change committed as 165245

Expand Messages | Collapse Messages