Fix incorrect assumption in IDMap and SmallMap tests.

Fix incorrect assumption in IDMap and SmallMap tests.

Some of the tests assumed that base::hash_map is ordered, which it is not. They
worked under libstdc++, but broke in libc++ builds.

BUG=327334
R=thakis@chromium.org, brettw@chromium.org
TEST=base_unittests

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246644

[earthdok, 2014-01-16 15:58:31]

Please take a look.

[earthdok, 2014-01-22 18:02:45]

On 2014/01/16 15:58:31, earthdok wrote:
> Please take a look.

ping?

[earthdok, 2014-01-23 12:24:40]

Adding another reviewer after a week. Please take a look.

[Nico, 2014-01-23 16:05:57]

lgtm, but try the == thing first please.

https://codereview.chromium.org/130783003/diff/1/base/containers/small_map_un...
File base/containers/small_map_unittest.cc (left):

https://codereview.chromium.org/130783003/diff/1/base/containers/small_map_un...
base/containers/small_map_unittest.cc:159: for (typename inner::iterator ia_it =
ia.begin(), ib_it = ib.begin();
This loop is the problem, right? Does `return a == b`work by now? (I think we
stopped supporting msvs2008 since this code was written.) If not, what's the
rror?

https://codereview.chromium.org/130783003/diff/1/base/id_map_unittest.cc
File base/id_map_unittest.cc (right):

https://codereview.chromium.org/130783003/diff/1/base/id_map_unittest.cc#newc...
base/id_map_unittest.cc:212: int32 ids_in_iteration_order[kCount];
Add:

// IDMap uses a hash_map, which has no predictable iteration order.

[earthdok, 2014-01-23 17:10:00]

On 2014/01/23 16:05:57, Nico wrote:
> lgtm, but try the == thing first please.
> 
>
https://codereview.chromium.org/130783003/diff/1/base/containers/small_map_un...
> File base/containers/small_map_unittest.cc (left):
> 
>
https://codereview.chromium.org/130783003/diff/1/base/containers/small_map_un...
> base/containers/small_map_unittest.cc:159: for (typename inner::iterator ia_it
=
> ia.begin(), ib_it = ib.begin();
> This loop is the problem, right? Does `return a == b`work by now? (I think we
> stopped supporting msvs2008 since this code was written.) If not, what's the
> rror?

Won't compile on Android:
http://build.chromium.org/p/tryserver.chromium/builders/android_dbg/builds/14...
http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...

[Nico, 2014-01-23 17:10:50]

Ok, thanks for checking.


On Thu, Jan 23, 2014 at 9:10 AM, <earthdok@chromium.org> wrote:

> On 2014/01/23 16:05:57, Nico wrote:
>
>> lgtm, but try the == thing first please.
>>
>
>
> https://codereview.chromium.org/130783003/diff/1/base/
> containers/small_map_unittest.cc
>
>> File base/containers/small_map_unittest.cc (left):
>>
>
>
> https://codereview.chromium.org/130783003/diff/1/base/
> containers/small_map_unittest.cc#oldcode159
>
>> base/containers/small_map_unittest.cc:159: for (typename inner::iterator
>> ia_it
>>
> =
>
>> ia.begin(), ib_it = ib.begin();
>> This loop is the problem, right? Does `return a == b`work by now? (I
>> think we
>> stopped supporting msvs2008 since this code was written.) If not, what's
>> the
>> rror?
>>
>
> Won't compile on Android:
> http://build.chromium.org/p/tryserver.chromium/builders/
> android_dbg/builds/142131/steps/compile/logs/stdio
> http://build.chromium.org/p/tryserver.chromium/builders/
> android_clang_dbg/builds/108940/steps/compile/logs/stdio
>
>
> https://codereview.chromium.org/130783003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[earthdok, 2014-01-23 18:17:49]

Committed patchset #7 manually as r246644 (presubmit successful).