Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307813002: Devtools[LayoutEditor]: Correctly handle new values (Closed)

Created:
5 years, 4 months ago by sergeyv
Modified:
5 years, 4 months ago
Reviewers:
dgozman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools[LayoutEditor]: Correctly handle new values 1. Truncate trailing zeroes in doubles. 2. Ignore negative values in paddings. BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201004

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M Source/core/inspector/LayoutEditor.cpp View 1 2 chunks +24 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sergeyv
5 years, 4 months ago (2015-08-21 04:55:39 UTC) #2
dgozman
lgtm with comment https://codereview.chromium.org/1307813002/diff/1/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1307813002/diff/1/Source/core/inspector/LayoutEditor.cpp#newcode135 Source/core/inspector/LayoutEditor.cpp:135: bool isValidValue(CSSPropertyID propertyId, float newValue) toValidValue ...
5 years, 4 months ago (2015-08-21 17:36:33 UTC) #3
sergeyv
https://codereview.chromium.org/1307813002/diff/1/Source/core/inspector/LayoutEditor.cpp File Source/core/inspector/LayoutEditor.cpp (right): https://codereview.chromium.org/1307813002/diff/1/Source/core/inspector/LayoutEditor.cpp#newcode135 Source/core/inspector/LayoutEditor.cpp:135: bool isValidValue(CSSPropertyID propertyId, float newValue) On 2015/08/21 17:36:33, dgozman ...
5 years, 4 months ago (2015-08-21 17:59:01 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307813002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307813002/20001
5 years, 4 months ago (2015-08-21 17:59:17 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 19:07:05 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201004

Powered by Google App Engine
This is Rietveld 408576698