Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307803003: Introduce nextPositionOf() for VisiblePosition (Closed)

Created:
5 years, 3 months ago by yosin_UTC9
Modified:
5 years, 3 months ago
Reviewers:
tkent
CC:
blink-reviews, krit, szager+layoutwatch_chromium.org, blink-reviews-style_chromium.org, zoltan1, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, blink-reviews-rendering, f(malita), jchaffraix+rendering, gyuyoung2, Stephen Chennney, rwlbuis, pdr+svgwatchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce nextPositionOf() for VisiblePosition This patch introduces |nextPositionOf()| function for |VisiblePosition| as replacement of |VisiblePosition::next()| to simplify |VisiblePosition| class for ease of templataizing |VisiblePosition| class to introduce composed tree version of |VisiblePosition|, since an implementation of |VisiblePosition::next()| can be implemented with public member functions of |VisiblePosition| class. Note: http://crrev.com/1310043003introduces |previousPositionOf()|. This patch is a preparation of making selection to handle granularity for web component, http://crrev.com/1277863002 BUG=513568 TEST=n/a; No behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201389

Patch Set 1 : 2015-08-28T15:33:04 #

Patch Set 2 : 2015-08-28T18:13:02 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -59 lines) Patch
M Source/core/editing/EditingUtilities.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/Editor.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/FrameSelection.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/PlainTextRange.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.cpp View 1 1 chunk +6 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleSelection.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/commands/ApplyBlockElementCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/ApplyStyleCommand.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/commands/BreakBlockquoteCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/CompositeEditCommand.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/commands/DeleteSelectionCommand.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/IndentOutdentCommand.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/editing/commands/InsertListCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/commands/ReplaceSelectionCommand.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/editing/commands/TypingCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/serializers/StyledMarkupSerializer.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/frame/LocalFrame.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/layout/PendingSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGTextContentElement.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
yosin_UTC9
PTAL To keep patch size small, this patch replaces next() only, following patch introduces previousPositionOf() ...
5 years, 3 months ago (2015-08-28 06:54:38 UTC) #2
tkent
lgtm
5 years, 3 months ago (2015-08-28 07:06:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307803003/1
5 years, 3 months ago (2015-08-28 07:12:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99947)
5 years, 3 months ago (2015-08-28 08:20:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307803003/1
5 years, 3 months ago (2015-08-28 08:43:17 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/99988)
5 years, 3 months ago (2015-08-28 08:49:36 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307803003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307803003/20001
5 years, 3 months ago (2015-08-28 09:13:55 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 10:24:10 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201389

Powered by Google App Engine
This is Rietveld 408576698