Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 13078005: Remove retrial of reading from a cached file. (Closed)

Created:
7 years, 9 months ago by hidehiko
Modified:
7 years, 9 months ago
Reviewers:
hashimoto, kinaba
CC:
chromium-reviews, achuith+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Remove retrial of reading from a cached file. The retry function has an issue that breaks the buffer content. Seems like it is not necessary, so just clean it up. BUG=223603 TEST=Ran unit_tests and tested manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190553

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -32 lines) Patch
M chrome/browser/chromeos/drive/drive_url_request_job.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_url_request_job.cc View 1 6 chunks +14 lines, -28 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
hidehiko
Thank you for your review in advance, - hidehiko
7 years, 9 months ago (2013-03-26 03:23:42 UTC) #1
hashimoto
https://codereview.chromium.org/13078005/diff/1/chrome/browser/chromeos/drive/drive_url_request_job.cc File chrome/browser/chromeos/drive/drive_url_request_job.cc (right): https://codereview.chromium.org/13078005/diff/1/chrome/browser/chromeos/drive/drive_url_request_job.cc#newcode702 chrome/browser/chromeos/drive/drive_url_request_job.cc:702: BytesReadCompleted(); Do we need to call this? If so, ...
7 years, 9 months ago (2013-03-26 03:33:21 UTC) #2
kinaba
lgtm
7 years, 9 months ago (2013-03-26 04:03:15 UTC) #3
hidehiko
Thank you for your review. PTAL? https://codereview.chromium.org/13078005/diff/1/chrome/browser/chromeos/drive/drive_url_request_job.cc File chrome/browser/chromeos/drive/drive_url_request_job.cc (right): https://codereview.chromium.org/13078005/diff/1/chrome/browser/chromeos/drive/drive_url_request_job.cc#newcode702 chrome/browser/chromeos/drive/drive_url_request_job.cc:702: BytesReadCompleted(); On 2013/03/26 ...
7 years, 9 months ago (2013-03-26 04:06:06 UTC) #4
hashimoto
lgtm
7 years, 9 months ago (2013-03-26 04:11:28 UTC) #5
hidehiko
7 years, 9 months ago (2013-03-26 04:14:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r190553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698