Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(588)

Unified Diff: content/browser/child_process_launcher.cc

Issue 1307793003: Execute operations of ChildProcessLauncher on launcher thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Apply Yaron's comments Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/child_process_launcher.cc
diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc
index 55037881bb67a00ecf80440d802d4e93bdbb1631..6fd30ab1f09a99f22e4bcd042a99a46dca9854ac 100644
--- a/content/browser/child_process_launcher.cc
+++ b/content/browser/child_process_launcher.cc
@@ -70,18 +70,14 @@ void RecordHistogramsOnLauncherThread(base::TimeDelta launch_time) {
}
#if defined(OS_ANDROID)
-// TODO(sievers): Remove this by defining better what happens on what
-// thread in the corresponding Java code.
void OnChildProcessStartedAndroid(const NotifyCallback& callback,
BrowserThread::ID client_thread_id,
const base::TimeTicks begin_launch_time,
base::ScopedFD ipcfd,
base::ProcessHandle handle) {
- // This can be called on the launcher thread or UI thread.
+ // This will be called on the launcher thread.
base::TimeDelta launch_time = base::TimeTicks::Now() - begin_launch_time;
- BrowserThread::PostTask(
- BrowserThread::PROCESS_LAUNCHER, FROM_HERE,
- base::Bind(&RecordHistogramsOnLauncherThread, launch_time));
+ RecordHistogramsOnLauncherThread(launch_time);
base::Closure callback_on_client_thread(
base::Bind(callback, false, base::Passed(&ipcfd),

Powered by Google App Engine
This is Rietveld 408576698