content/browser/child_process_launcher.cc - Issue 1307793003: Execute operations of ChildProcessLauncher on launcher thread

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/child_process_launcher.cc

Issue 1307793003: Execute operations of ChildProcessLauncher on launcher thread (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Apply Yaron's comments Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/init/NativeInitializationController.java ('K') | « content/browser/android/child_process_launcher_android.cc ('k') | content/public/android/java/src/org/chromium/content/browser/BindingManagerImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/child_process_launcher.cc

diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc

index 262e6a8ac90ea0c0e6b4097dd90b0f32382257b6..d7b8aa9a0978a7cbce51e14592998e642d56e386 100644

--- a/content/browser/child_process_launcher.cc

+++ b/content/browser/child_process_launcher.cc

@@ -78,11 +78,9 @@ void OnChildProcessStartedAndroid(const NotifyCallback& callback,

const base::TimeTicks begin_launch_time,

base::ScopedFD ipcfd,

base::ProcessHandle handle) {

- // This can be called on the launcher thread or UI thread.

+ // This will be called on the launcher thread.

base::TimeDelta launch_time = base::TimeTicks::Now() - begin_launch_time;

- BrowserThread::PostTask(

- BrowserThread::PROCESS_LAUNCHER, FROM_HERE,

- base::Bind(&RecordHistogramsOnLauncherThread, launch_time));

+ RecordHistogramsOnLauncherThread(launch_time);

base::Closure callback_on_client_thread(

base::Bind(callback, false, base::Passed(&ipcfd),