Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307763004: Sync remaining components_unittests with GN (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, wjmaclean, browser-components-watch_chromium.org, jam, raymes+watch_chromium.org, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, markusheintz_, wifiprefetch-reviews_google.com, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync remaining components_unittests with GN This syncs all remaining non-blocked tests from GYP to GN. This does not include NaCl related ones (nacl isn't completely hooked up) nor web_modal (blocked on bug 522654) nor constrained_window (blocked 0on web_modal). CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg Committed: https://crrev.com/29444ff4560dfb889c3e158a3908536bad1372eb Cr-Commit-Position: refs/heads/master@{#345500}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix gn check #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -9 lines) Patch
M components/BUILD.gn View 5 chunks +7 lines, -3 lines 0 comments Download
M components/autofill/content/common/BUILD.gn View 1 1 chunk +5 lines, -0 lines 2 comments Download
M components/autofill/content/renderer/BUILD.gn View 1 2 1 chunk +18 lines, -1 line 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/language_usage_metrics/BUILD.gn View 1 chunk +12 lines, -0 lines 0 comments Download
M components/network_time/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/os_crypt/BUILD.gn View 1 2 1 chunk +14 lines, -0 lines 0 comments Download
M components/power/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/precache/core/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download
M components/ui/zoom/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/update_client/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/wallpaper/BUILD.gn View 1 2 3 chunks +19 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (8 generated)
brettw
5 years, 4 months ago (2015-08-24 18:04:56 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763004/20001
5 years, 4 months ago (2015-08-24 18:05:23 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/125249)
5 years, 4 months ago (2015-08-24 18:57:32 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763004/20001
5 years, 4 months ago (2015-08-24 19:52:50 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_rel/builds/125330)
5 years, 4 months ago (2015-08-24 20:40:12 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763004/40001
5 years, 4 months ago (2015-08-24 21:45:02 UTC) #12
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-24 22:50:07 UTC) #14
Dirk Pranke
lgtm https://codereview.chromium.org/1307763004/diff/40001/components/autofill/content/common/BUILD.gn File components/autofill/content/common/BUILD.gn (right): https://codereview.chromium.org/1307763004/diff/40001/components/autofill/content/common/BUILD.gn#newcode17 components/autofill/content/common/BUILD.gn:17: "//skia", Does this imply that there's a bug ...
5 years, 4 months ago (2015-08-25 19:56:26 UTC) #15
brettw
https://codereview.chromium.org/1307763004/diff/40001/components/autofill/content/common/BUILD.gn File components/autofill/content/common/BUILD.gn (right): https://codereview.chromium.org/1307763004/diff/40001/components/autofill/content/common/BUILD.gn#newcode17 components/autofill/content/common/BUILD.gn:17: "//skia", On 2015/08/25 19:56:26, Dirk Pranke wrote: > Does ...
5 years, 3 months ago (2015-08-25 23:37:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307763004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307763004/40001
5 years, 3 months ago (2015-08-25 23:38:55 UTC) #18
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-08-26 00:26:15 UTC) #19
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 00:27:07 UTC) #20
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/29444ff4560dfb889c3e158a3908536bad1372eb
Cr-Commit-Position: refs/heads/master@{#345500}

Powered by Google App Engine
This is Rietveld 408576698