[Offline pages] Adding capability to free up space used by Offline pages

chrome/android/java/res/layout/eb_offline_pages_storage_space_header.xml

Index: chrome/android/java/res/layout/eb_offline_pages_storage_space_header.xml
diff --git a/chrome/android/java/res/layout/eb_promo_header.xml b/chrome/android/java/res/layout/eb_offline_pages_storage_space_header.xml
similarity index 67%
copy from chrome/android/java/res/layout/eb_promo_header.xml
copy to chrome/android/java/res/layout/eb_offline_pages_storage_space_header.xml
index 99169b8e1bbc0d6c6c996a418fdcee43df7e3bf0..b16168008d688ae62308a476505b80ad49f89e8f 100644
--- a/chrome/android/java/res/layout/eb_promo_header.xml
+++ b/chrome/android/java/res/layout/eb_offline_pages_storage_space_header.xml
@@ -13,20 +13,19 @@
     android:padding="16dp" >
 
     <TextView
-        android:id="@+id/title"
+        android:id="@+id/offline_pages_storage_title"

[Kibeom Kim (inactive), 2015/08/21 20:19:39]

fyi (maybe you already knew, but just in case):

android:id doesn't need to be globally unique, as long as it's local to the View
where we call findViewById().

[fgorski, 2015/08/21 22:09:38]

I suspected that. Thanks for confirming.
I decided to simplify the naming a bit.

         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
-        android:text="@string/enhanced_bookmark_sign_in_promo_title"
+        android:text="@string/offline_pages_storage_space_title"
         android:textColor="@color/default_text_color"
         android:textSize="16sp"
         android:textStyle="bold" />
 
     <TextView
-        android:id="@+id/description"
+        android:id="@+id/offline_pages_storage_size"
         android:layout_width="wrap_content"
         android:layout_height="wrap_content"
         android:layout_marginTop="8dp"
-        android:text="@string/enhanced_bookmark_sign_in_promo_description"
         android:textColor="@color/default_text_color"
         android:textSize="14sp" />
 
@@ -39,24 +38,14 @@
         android:orientation="horizontal" >
 
         <Button
-            android:id="@+id/no_thanks"
+            android:id="@+id/offline_pages_free_up_space_btn"
             style="@style/ButtonCompatBorderless"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="@string/enhanced_bookmark_sign_in_promo_no_thanks"
+            android:text="@string/offline_pages_free_up_space_title"
             android:textAllCaps="true"
             android:textColor="@color/light_active_color"
             android:textSize="15sp" />
-
-        <org.chromium.ui.widget.ButtonCompat
-            android:id="@+id/sign_in"
-            android:layout_width="wrap_content"
-            android:layout_height="wrap_content"
-            android:text="@string/enhanced_bookmark_sign_in_promo_sign_in"
-            android:textAllCaps="true"
-            android:textColor="@android:color/white"
-            android:textSize="15sp"
-            chrome:buttonColor="@color/light_active_color" />
     </LinearLayout>
 
 </LinearLayout>