Warn about extractTypeNameFromFunctionName usage

Warn about extractTypeNameFromFunctionName usage

BUG=519650
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201520

[kouhei (in TOK), 2015-09-01 01:29:26]

kouhei@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[tkent, 2015-09-01 01:36:16]

https://codereview.chromium.org/1307743008/diff/1/Source/wtf/InstanceCounter.h
File Source/wtf/InstanceCounter.h (right):

https://codereview.chromium.org/1307743008/diff/1/Source/wtf/InstanceCounter....
Source/wtf/InstanceCounter.h:37: // Warning: Using
extractTypeNameFromFunctionName bloats binary size.
Can we warp the function with ENABLE(ASSERT) || ENABLE(GC_PROFILING)?

[haraken, 2015-09-01 01:38:13]

LGTM

On 2015/09/01 01:36:16, tkent wrote:
> https://codereview.chromium.org/1307743008/diff/1/Source/wtf/InstanceCounter.h
> File Source/wtf/InstanceCounter.h (right):
> 
>
https://codereview.chromium.org/1307743008/diff/1/Source/wtf/InstanceCounter....
> Source/wtf/InstanceCounter.h:37: // Warning: Using
> extractTypeNameFromFunctionName bloats binary size.
> Can we warp the function with ENABLE(ASSERT) || ENABLE(GC_PROFILING)?

We can't do that until ssid@ reverts a couple of CLs.

[tkent, 2015-09-01 01:42:28]

On 2015/09/01 01:38:13, haraken wrote:
> We can't do that until ssid@ reverts a couple of CLs.

I see.  We should have TODO(kouhei) comment about it then.  lgtm.

[kouhei (in TOK), 2015-09-01 02:29:14]

The CQ bit was checked by kouhei@chromium.org

[kouhei (in TOK), 2015-09-01 02:29:15]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/1307743008/#ps20001
(title: "add todo")

[commit-bot: I haz the power, 2015-09-01 02:29:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307743008/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307743008/20001

[kouhei (in TOK), 2015-09-01 02:29:35]

On 2015/09/01 01:42:28, tkent wrote:
> On 2015/09/01 01:38:13, haraken wrote:
> > We can't do that until ssid@ reverts a couple of CLs.
> 
> I see.  We should have TODO(kouhei) comment about it then.  lgtm.

Done.

[commit-bot: I haz the power, 2015-09-01 05:02:39]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201520