Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 130773004: Start moving context menu code to RenderFrame. (Closed)

Created:
6 years, 10 months ago by jam
Modified:
6 years, 10 months ago
Reviewers:
nasko
CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, tfarina, jam, joi+watch-content_chromium.org, darin-cc_chromium.org, ajwong+watch_chromium.org, android-webview-reviews_chromium.org, jochen+watch_chromium.org, miu+watch_chromium.org, site-isolation-reviews_chromium.org
Visibility:
Public.

Description

Start moving context menu code to RenderFrame. The selection code will have to move as well. That will happen in future changes. BUG=304341 R=nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248091

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+442 lines, -452 lines) Patch
M android_webview/native/aw_web_contents_view_delegate.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M android_webview/native/aw_web_contents_view_delegate.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/apps/app_browsertest.cc View 1 2 3 7 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/custom_handlers/protocol_handler_registry_browsertest.cc View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/download/download_browsertest.cc View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/extensions/api/web_navigation/web_navigation_apitest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_context_menu_browsertest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.h View 1 2 3 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 2 3 5 chunks +16 lines, -8 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_browsertest.cc View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_test_util.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_test_util.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/translate/translate_manager_browsertest.cc View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/android/tab_contents/chrome_web_contents_view_delegate_android.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/chrome_web_contents_view_delegate_mac.mm View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/tab_contents/render_view_context_menu_mac.mm View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/tab_contents/chrome_web_contents_view_delegate_gtk.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/tab_contents/render_view_context_menu_gtk.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/panels/panel_extension_browsertest.cc View 1 2 3 6 chunks +7 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/chrome_web_contents_view_delegate_views.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.h View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_views.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_win.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tab_contents/render_view_context_menu_win.cc View 1 2 3 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/frame_host/render_frame_host_delegate.h View 1 2 3 2 chunks +7 lines, -1 line 0 comments Download
M content/browser/frame_host/render_frame_host_impl.h View 1 2 3 3 chunks +6 lines, -0 lines 0 comments Download
M content/browser/frame_host/render_frame_host_impl.cc View 1 2 3 5 chunks +29 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_view_host_delegate.h View 1 2 3 2 chunks +0 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.h View 1 2 3 4 chunks +0 lines, -6 lines 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 2 3 3 chunks +0 lines, -27 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 4 2 chunks +10 lines, -9 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_gtk.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_guest.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_guest.cc View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/web_contents/web_contents_view_mac.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/web_contents/web_contents_view_mac.mm View 1 2 3 2 chunks +4 lines, -2 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/common/frame_messages.h View 1 2 3 4 chunks +64 lines, -0 lines 2 comments Download
M content/common/view_messages.h View 1 2 3 6 chunks +0 lines, -62 lines 0 comments Download
M content/content_tests.gypi View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M content/port/browser/render_view_host_delegate_view.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M content/public/browser/render_frame_host.h View 1 2 3 2 chunks +9 lines, -0 lines 2 comments Download
M content/public/browser/render_view_host.h View 1 2 3 3 chunks +0 lines, -9 lines 0 comments Download
M content/public/browser/web_contents_view_delegate.h View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M content/public/renderer/render_view_observer.h View 1 2 3 2 chunks +0 lines, -4 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 2 3 6 chunks +35 lines, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 1 2 3 7 chunks +118 lines, -2 lines 0 comments Download
A + content/renderer/render_frame_impl_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_browsertest.cc View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M content/renderer/render_view_impl.h View 1 2 3 9 chunks +0 lines, -38 lines 0 comments Download
M content/renderer/render_view_impl.cc View 1 2 3 13 chunks +5 lines, -134 lines 0 comments Download
D content/renderer/render_view_impl_unittest.cc View 1 2 3 1 chunk +0 lines, -41 lines 0 comments Download
M content/renderer/render_widget.h View 1 2 3 6 chunks +11 lines, -7 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 4 chunks +7 lines, -10 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate.h View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_android.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_gtk.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_mac.mm View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/shell/browser/shell_web_contents_view_delegate_win.cc View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jam
6 years, 10 months ago (2014-01-30 21:58:53 UTC) #1
nasko
LGTM with a nit. https://codereview.chromium.org/130773004/diff/70001/content/common/frame_messages.h File content/common/frame_messages.h (right): https://codereview.chromium.org/130773004/diff/70001/content/common/frame_messages.h#newcode113 content/common/frame_messages.h:113: // Executes custom context menu ...
6 years, 10 months ago (2014-01-31 00:38:17 UTC) #2
jam
6 years, 10 months ago (2014-01-31 00:45:52 UTC) #3 
https://codereview.chromium.org/130773004/diff/70001/content/common/frame_mes...
File content/common/frame_messages.h (right):

https://codereview.chromium.org/130773004/diff/70001/content/common/frame_mes...
content/common/frame_messages.h:113: // Executes custom context menu action that
was provided from WebKit.
On 2014/01/31 00:38:17, nasko wrote:
> nit: Blink?

Done.

https://codereview.chromium.org/130773004/diff/70001/content/public/browser/r...
File content/public/browser/render_frame_host.h (right):

https://codereview.chromium.org/130773004/diff/70001/content/public/browser/r...
content/public/browser/render_frame_host.h:44: // Executes custom context menu
action that was provided from WebKit.
On 2014/01/31 00:38:17, nasko wrote:
> nit: Blink?

Done.

Powered by Google App Engine
This is Rietveld 408576698