Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Issue 1307713002: cc: Allow transparent layers with background filters to render (Closed)

Created:
5 years, 4 months ago by hendrikw
Modified:
5 years, 4 months ago
Reviewers:
enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

cc: Allow transparent layers with background filters to render If we have a background filter, we still need to render the fully transparent stuff since the filter will still change what's beneath it. +test BUG=497522 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/c266f7bac110aebada963292e67c51fd3195bb9a Cr-Commit-Position: refs/heads/master@{#344912}

Patch Set 1 #

Patch Set 2 : update test comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
M cc/trees/draw_property_utils.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
hendrikw
PTAL, thanks!
5 years, 4 months ago (2015-08-20 23:38:03 UTC) #2
enne (OOO)
lgtm
5 years, 4 months ago (2015-08-21 17:36:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307713002/20001
5 years, 4 months ago (2015-08-21 17:37:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/59102)
5 years, 4 months ago (2015-08-21 20:40:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307713002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307713002/20001
5 years, 4 months ago (2015-08-21 20:51:16 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-21 23:41:40 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 23:42:49 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c266f7bac110aebada963292e67c51fd3195bb9a
Cr-Commit-Position: refs/heads/master@{#344912}

Powered by Google App Engine
This is Rietveld 408576698