Add BUILD.gn for nacl_io

Add BUILD.gn for nacl_io

BUG=512899
Committed: https://crrev.com/214a01b252a57cbf1a4b9e73c9d1d92d89710f7d
Cr-Commit-Position: refs/heads/master@{#346419}

[Sergey Ulanov, 2015-08-27 23:06:06]

sergeyu@chromium.org changed reviewers:
+ sbc@chromium.org

[binji, 2015-08-27 23:29:40]

binji@chromium.org changed reviewers:
+ binji@chromium.org

[binji, 2015-08-27 23:29:40]

https://codereview.chromium.org/1307693003/diff/1/native_client_sdk/src/libra...
File native_client_sdk/src/libraries/nacl_io/BUILD.gn (right):

https://codereview.chromium.org/1307693003/diff/1/native_client_sdk/src/libra...
native_client_sdk/src/libraries/nacl_io/BUILD.gn:22: "devfs/dev_fs.cc",
Is it possible to generate this list from python like the gyp build?
https://code.google.com/p/chromium/codesearch#chromium/src/native_client_sdk/...

[Sergey Ulanov, 2015-08-28 00:15:53]

sergeyu@chromium.org changed reviewers:
+ dpranke@chromium.org

[Sergey Ulanov, 2015-08-28 00:15:54]

+dpranke@chromium.org
Dirk, should we prefer listing the files in BUILD.gn, or is it acceptable to add
the exception to run the python script?

https://codereview.chromium.org/1307693003/diff/1/native_client_sdk/src/libra...
File native_client_sdk/src/libraries/nacl_io/BUILD.gn (right):

https://codereview.chromium.org/1307693003/diff/1/native_client_sdk/src/libra...
native_client_sdk/src/libraries/nacl_io/BUILD.gn:22: "devfs/dev_fs.cc",
On 2015/08/27 23:29:40, binji wrote:
> Is it possible to generate this list from python like the gyp build?
>
https://code.google.com/p/chromium/codesearch#chromium/src/native_client_sdk/...

It is possible, but discouraged. Problem is that it slows down gn significantly.

[Dirk Pranke, 2015-08-28 00:34:04]

On 2015/08/28 00:15:54, Sergey Ulanov wrote:
> Dirk, should we prefer listing the files in BUILD.gn, or is it acceptable to
add
> the exception to run the python script?

You should prefer to list the files explicitly unless they change rapidly. I'm
guessing that's not the case here, and the list is relatively short (~125 lines,
looks like)?

[binji, 2015-08-28 00:44:53]

On 2015/08/28 at 00:34:04, dpranke wrote:
> On 2015/08/28 00:15:54, Sergey Ulanov wrote:
> > Dirk, should we prefer listing the files in BUILD.gn, or is it acceptable to
add
> > the exception to run the python script?
> 
> You should prefer to list the files explicitly unless they change rapidly. I'm
guessing that's not the case here, and the list is relatively short (~125 lines,
looks like)?

Yes, the list hasn't changed in a while, so it's probably OK to duplicate. I'm
concerned that we won't see failures right away, though. What builder tests this
configuration?

[Dirk Pranke, 2015-08-28 00:59:36]

On Thu, Aug 27, 2015 at 5:44 PM, <binji@chromium.org> wrote:

> On 2015/08/28 at 00:34:04, dpranke wrote:
>
>> On 2015/08/28 00:15:54, Sergey Ulanov wrote:
>> > Dirk, should we prefer listing the files in BUILD.gn, or is it
>> acceptable to
>>
> add
>
>> > the exception to run the python script?
>>
>
> You should prefer to list the files explicitly unless they change rapidly.
>> I'm
>>
> guessing that's not the case here, and the list is relatively short (~125
> lines,
> looks like)?
>
> Yes, the list hasn't changed in a while, so it's probably OK to duplicate.
> I'm
> concerned that we won't see failures right away, though. What builder
> tests this
> configuration?
>

We have multiple builders in the CQ and on the main chromium waterfall that
test
GN builds, but AFAIK they do not build anything from the native_client_sdk
directory.

What bots normally build stuff from the SDK (or what targets)?

-- Dirk

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Sergey Ulanov, 2015-08-28 05:58:10]

On 2015/08/28 00:59:36, Dirk Pranke wrote:
> On Thu, Aug 27, 2015 at 5:44 PM, <mailto:binji@chromium.org> wrote:
> > Yes, the list hasn't changed in a while, so it's probably OK to duplicate.
> > I'm
> > concerned that we won't see failures right away, though. What builder
> > tests this
> > configuration?
> >
> 
> We have multiple builders in the CQ and on the main chromium waterfall that
> test
> GN builds, but AFAIK they do not build anything from the native_client_sdk
> directory.
> 
> What bots normally build stuff from the SDK (or what targets)?

nacl_io is going to be built on all bots that build remoting/webapp once I land
this CL: https://codereview.chromium.org/1312463005/

[binji, 2015-08-28 16:29:04]

On 2015/08/28 at 05:58:10, sergeyu wrote:
> On 2015/08/28 00:59:36, Dirk Pranke wrote:
> > On Thu, Aug 27, 2015 at 5:44 PM, <mailto:binji@chromium.org> wrote:
> > > Yes, the list hasn't changed in a while, so it's probably OK to duplicate.
> > > I'm
> > > concerned that we won't see failures right away, though. What builder
> > > tests this
> > > configuration?
> > >
> > 
> > We have multiple builders in the CQ and on the main chromium waterfall that
> > test
> > GN builds, but AFAIK they do not build anything from the native_client_sdk
> > directory.
> > 
> > What bots normally build stuff from the SDK (or what targets)?
> 
> nacl_io is going to be built on all bots that build remoting/webapp once I
land this CL: https://codereview.chromium.org/1312463005/

OK, lgtm w/ explicit list

[Sergey Ulanov, 2015-08-31 17:43:07]

Patchset #2 (id:20001) has been deleted

[Sergey Ulanov, 2015-08-31 17:44:04]

The CQ bit was checked by sergeyu@chromium.org

[commit-bot: I haz the power, 2015-08-31 17:44:20]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1307693003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1307693003/1

[commit-bot: I haz the power, 2015-08-31 18:14:10]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-31 18:14:41]

Patchset 1 (id:??) landed as
https://crrev.com/214a01b252a57cbf1a4b9e73c9d1d92d89710f7d
Cr-Commit-Position: refs/heads/master@{#346419}