Source/core/css/resolver/StyleBuilderConverter.h - Issue 1307673003: Made CSSPrimitiveValue::getString() only work for String types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/resolver/StyleBuilderConverter.h

Issue 1307673003: Made CSSPrimitiveValue::getString() only work for String types (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@split_out_pair

Patch Set: Review feedback Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/resolver/StyleBuilderConverter.h

diff --git a/Source/core/css/resolver/StyleBuilderConverter.h b/Source/core/css/resolver/StyleBuilderConverter.h

index 6f11b7f098b9cd56f6a7d01415b9fc4bf7bd32f3..b6bfd25be0f9a706d9b24689605f0da1f35e10a0 100644

--- a/Source/core/css/resolver/StyleBuilderConverter.h

+++ b/Source/core/css/resolver/StyleBuilderConverter.h

@@ -157,6 +157,7 @@ AtomicString StyleBuilderConverter::convertString(StyleResolverState&, CSSValue*

CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value);

if (primitiveValue->getValueID() == IdForNone)

return nullAtom;

+ ASSERT(primitiveValue->isString());

return AtomicString(primitiveValue->getStringValue());

}

« no previous file with comments | « Source/core/css/CSSPrimitiveValue.cpp ('k') | Source/core/css/resolver/StyleBuilderConverter.cpp » ('j') | Source/web/WebAXObject.cpp » ('J')