Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(934)

Unified Diff: pkg/analysis_server/lib/src/domains/analysis/navigation.dart

Issue 1307663007: Rename NavigationHolder to NavigationCollector. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/analysis_server/lib/src/domains/analysis/navigation.dart
diff --git a/pkg/analysis_server/lib/src/domains/analysis/navigation.dart b/pkg/analysis_server/lib/src/domains/analysis/navigation.dart
index 859cd7cf92d21a8fc614a81789d9a443ef1c60e2..f323b17bde96dc884c9eeef2883a4f91721d466b 100644
--- a/pkg/analysis_server/lib/src/domains/analysis/navigation.dart
+++ b/pkg/analysis_server/lib/src/domains/analysis/navigation.dart
@@ -18,28 +18,28 @@ import 'package:analyzer/src/generated/source.dart' show Source;
/**
* Compute all known navigation information for the given part of [source].
*/
-NavigationHolderImpl computeNavigation(AnalysisServer server,
+NavigationCollectorImpl computeNavigation(AnalysisServer server,
AnalysisContext context, Source source, int offset, int length) {
- NavigationHolderImpl holder = new NavigationHolderImpl();
+ NavigationCollectorImpl collector = new NavigationCollectorImpl();
List<NavigationContributor> contributors =
server.serverPlugin.navigationContributors;
for (NavigationContributor contributor in contributors) {
try {
- contributor.computeNavigation(holder, context, source, offset, length);
+ contributor.computeNavigation(collector, context, source, offset, length);
} catch (exception, stackTrace) {
AnalysisEngine.instance.logger.logError(
'Exception from navigation contributor: ${contributor.runtimeType}',
new CaughtException(exception, stackTrace));
}
}
- holder.sortRegions();
- return holder;
+ collector.sortRegions();
+ return collector;
}
/**
- * A concrete implementation of [NavigationHolder].
+ * A concrete implementation of [NavigationCollector].
*/
-class NavigationHolderImpl implements NavigationHolder {
+class NavigationCollectorImpl implements NavigationCollector {
/**
* A list of navigation regions.
*/
« no previous file with comments | « pkg/analysis_server/lib/src/domain_analysis.dart ('k') | pkg/analysis_server/lib/src/domains/analysis/navigation_dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698