Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 1307663002: Don't pass paintInvalidationContainer to LayoutBox::savePreviousBoxSizesIfNeeded() (Closed)

Created:
5 years, 4 months ago by Xianzhu
Modified:
5 years, 4 months ago
Reviewers:
pdr., trchen
CC:
blink-reviews, pdr+renderingwatchlist_chromium.org, zoltan1, szager+layoutwatch_chromium.org, eae+blinkwatch, leviw+renderwatch, blink-reviews-rendering, jchaffraix+rendering
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Don't pass paintInvalidationContainer to LayoutBox::savePreviousBoxSizesIfNeeded() We only need the size of the invalidation rect, so don't need paintInvalidationContainer to adjust the offset of the rect. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200957

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M Source/core/layout/LayoutBox.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/layout/LayoutBox.cpp View 1 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/layout/LayoutObject.h View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Xianzhu
5 years, 4 months ago (2015-08-20 22:31:06 UTC) #2
trchen
lgtm. nice catch!
5 years, 4 months ago (2015-08-20 22:43:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307663002/20001
5 years, 4 months ago (2015-08-20 22:45:38 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/96416)
5 years, 4 months ago (2015-08-21 00:11:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307663002/20001
5 years, 4 months ago (2015-08-21 00:29:42 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 04:02:13 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200957

Powered by Google App Engine
This is Rietveld 408576698