Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 1307653007: Fix assertion failure during out-of-order matching (Closed)

Created:
5 years, 3 months ago by Xianzhu
Modified:
5 years, 3 months ago
Reviewers:
pdr., chrishtr
CC:
blink-reviews, Rik, danakj, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Fix assertion failure during out-of-order matching The assertion failure occurs in the following sequence: - Out-of-order matching to n-th item; - Synchronized matching to (n+m)-th item; - Out-of-order matching to (n-k)-th item; - Out-of-order matching to (n+m+l)-th. The problem is that we only update nextItemToIndex during out-of-order matching, but not during synchronized matching, causing we tried to index already copied items (n to n+m). BUG=526590 TEST=DisplayItemListTest.OutOfOrderNoCrash Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201684

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -10 lines) Patch
M Source/platform/graphics/paint/DisplayItemList.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemList.cpp View 4 chunks +7 lines, -8 lines 0 comments Download
M Source/platform/graphics/paint/DisplayItemListTest.cpp View 1 2 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Xianzhu
5 years, 3 months ago (2015-09-02 22:14:49 UTC) #2
pdr.
LGTM https://codereview.chromium.org/1307653007/diff/1/Source/platform/graphics/paint/DisplayItemListTest.cpp File Source/platform/graphics/paint/DisplayItemListTest.cpp (right): https://codereview.chromium.org/1307653007/diff/1/Source/platform/graphics/paint/DisplayItemListTest.cpp#newcode519 Source/platform/graphics/paint/DisplayItemListTest.cpp:519: // Test for crbug.com/526590 No need for this ...
5 years, 3 months ago (2015-09-02 23:13:13 UTC) #3
Xianzhu
https://codereview.chromium.org/1307653007/diff/1/Source/platform/graphics/paint/DisplayItemListTest.cpp File Source/platform/graphics/paint/DisplayItemListTest.cpp (right): https://codereview.chromium.org/1307653007/diff/1/Source/platform/graphics/paint/DisplayItemListTest.cpp#newcode519 Source/platform/graphics/paint/DisplayItemListTest.cpp:519: // Test for crbug.com/526590 On 2015/09/02 23:13:12, pdr wrote: ...
5 years, 3 months ago (2015-09-02 23:21:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307653007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307653007/40001
5 years, 3 months ago (2015-09-02 23:22:01 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 00:28:00 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201684

Powered by Google App Engine
This is Rietveld 408576698