Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(472)

Unified Diff: tests/standalone/standalone.status

Issue 1307653002: Mark invalid package config tests as 'Crash, OK' for analyzer. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/standalone/standalone.status
diff --git a/tests/standalone/standalone.status b/tests/standalone/standalone.status
index 5d7dc8b8825675f260d68ecca84db1b1465fb587..fcf9ae37d507348d7ce0c54867a78f4ae571ed4e 100644
--- a/tests/standalone/standalone.status
+++ b/tests/standalone/standalone.status
@@ -167,11 +167,10 @@ package/scenarios/packages_dir_only/packages_dir_only_test: CompileTimeError
package/scenarios/packages_file_only/packages_file_only_test: CompileTimeError
package/scenarios/both_dir_and_file/prefers_packages_file_test: CompileTimeError
package/scenarios/packages_file_in_parent/sub/packages_file_in_parent_test: CompileTimeError
-package/scenarios/invalid/non_existent_packages_file_test: Crash # Issue 24123
-package/scenarios/invalid/invalid_utf8_test: Crash # Issue 24127
-package/scenarios/invalid/invalid_package_name_test: Crash # Issue 24125
-package/scenarios/invalid/same_package_twice_test: Crash # Issue 24124
-package/scenarios/packages_file_strange_formatting/empty_package_dir_test: Crash # Issue 24126
+package/scenarios/invalid/non_existent_packages_file_test: Crash, OK # Analyzer exits on invalid package config
+package/scenarios/invalid/invalid_utf8_test: Crash, OK # Analyzer exits on invalid package config
+package/scenarios/invalid/invalid_package_name_test: Crash, OK # Analyzer exits on invalid package config
+package/scenarios/invalid/same_package_twice_test: Crash, OK # Analyzer exits on invalid package config
[ $system == windows ]
io/skipping_dart2js_compilations_test: Fail # Issue 19551.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698