Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1307643003: IWYU for base/memory/scoped_vector.h. (Closed)

Created:
5 years, 4 months ago by Lei Zhang
Modified:
5 years, 4 months ago
Reviewers:
keybuk, brettw
CC:
chromium-reviews, serviceworker-reviews, sadrul, yusukes+watch_chromium.org, zea+watch_chromium.org, tzik, posciak+watch_chromium.org, penghuang+watch-mandoline_chromium.org, vabr+watchlist_chromium.org, browser-components-watch_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, scheib+watch_chromium.org, dgrogan, piman+watch_chromium.org, tracing+reviews_chromium.org, peter+watch_chromium.org, markusheintz_, stevenjb+watch_chromium.org, kinuko+watch, qsr+mojo_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, horo+watch_chromium.org, toyoshim+midi_chromium.org, pvalenzuela+watch_chromium.org, jdduke+watch_chromium.org, ben+mojo_chromium.org, lcwu+watch_chromium.org, dzhioev+watch_chromium.org, jam, kinuko+serviceworker, raymes+watch_chromium.org, abarth-chromium, jbauman+watch_chromium.org, tburkard+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, tdresser+watch_chromium.org, jbudorick+watch_chromium.org, blink-worker-reviews_chromium.org, michaeln, mlamouri+watch-content_chromium.org, jsbell+serviceworker_chromium.org, mlamouri+watch-notifications_chromium.org, Paweł Hajdan Jr., viettrungluu+watch_chromium.org, tdanderson+views_chromium.org, nhiroki, feature-media-reviews_chromium.org, pam+watch_chromium.org, oshima+watch_chromium.org, kalyank, gunsch+watch_chromium.org, gcasto+watchlist_chromium.org, jsbell+idb_chromium.org, nona+watch_chromium.org, danakj+watch_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org, davidben+watch_chromium.org, media-router+watch_chromium.org, Ian Vollick, wfh+watch_chromium.org, maxbogue+watch_chromium.org, shuchen+watch_chromium.org, mcasas+watch_chromium.org, kinuko+fileapi, ozone-reviews_chromium.org, Aaron Boodman, gavinp+prer_chromium.org, klundberg+watch_chromium.org, plaree+watch_chromium.org, mmenke, cmumford, tfarina, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, cc-bugs_chromium.org, James Su, wjia+watch_chromium.org, scheduler-bugs_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

IWYU for base/memory/scoped_vector.h. List from: git gs base/memory/scoped_vector.h|cut -d: -f 1|uniq|xargs grep -L ScopedVector CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=keybuk@chromium.org Committed: https://crrev.com/7790a3535f2a81a03685eca31a32cf69ae0c114f Cr-Commit-Position: refs/heads/master@{#344925}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -107 lines) Patch
M ash/sticky_keys/sticky_keys_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/callback_internal.h View 1 chunk +0 lines, -3 lines 0 comments Download
M base/files/file_path_watcher_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/prefs/json_pref_store.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/trace_event/trace_buffer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M base/trace_event/trace_event_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/scheduler/scheduler_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/about_flags_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/drive/directory_loader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/abort_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/add_watcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/copy_entry_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_directory_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/create_file_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/delete_entry_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/execute_action_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/move_entry_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/remove_watcher_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/truncate_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/operations/write_file_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/throttled_file_system_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/enrollment/enterprise_enrollment_helper_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/gcd_private/gcd_private_api.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/language_settings_private/language_settings_private_delegate.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/api/platform_keys/verify_trust_api.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/extension_system_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/menu_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/test_extension_system.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/android/android_provider_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/media/router/media_router.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/password_manager/password_store_win.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/prerender/prerender_contents.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_service.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/supervised_user/supervised_user_site_list.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/supervised_user/supervised_user_whitelist_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/synced_session_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sessions/sessions_sync_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/multiple_client_sessions_sync_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/multiple_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_sessions_sync_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/single_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_sessions_sync_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/test/integration/two_client_typed_urls_sync_test.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/drive_backend_util.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync_file_system/drive_backend/metadata_database_index_on_disk.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/cocoa/history_menu_cocoa_controller.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/toolbar/toolbar_actions_model.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/views/hung_renderer_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_result_view.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/drive_internals_ui.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/foreign_session_handler.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/media_router/query_result_manager_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M chromecast/media/cma/filters/demuxer_stream_adapter_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/autofill/core/browser/webdata/web_data_service_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_pref_provider.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/content_settings/core/browser/content_settings_utils.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/domain_reliability/uploader.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/html_viewer/web_socket_handle_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/nacl/loader/nacl_ipc_adapter.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/content/browser/credential_manager_dispatcher.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_syncable_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/policy/core/common/schema.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/scheduler/child/task_queue_selector_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/search_engines/template_url_service_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/search_engines/util.h View 1 chunk +3 lines, -0 lines 0 comments Download
M components/signin/core/browser/account_reconcilor.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/update_client/update_response_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M components/url_matcher/url_matcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/url_matcher/url_matcher.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/indexed_db/indexed_db_backing_store.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/net/quota_policy_cookie_store_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/web_memory_allocator_dump_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/dwrite_font_platform_win.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_channel.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/gpu/gpu_command_buffer_stub.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_key.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/indexed_db/indexed_db_key_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/gpu_benchmarking_extension.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/history_controller.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/media/media_stream_video_track.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/pepper/video_encoder_shim.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/render_thread_impl_browsertest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/utility/utility_thread_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M device/bluetooth/bluetooth_device.cc View 1 chunk +1 line, -0 lines 0 comments Download
M device/bluetooth/bluetooth_device_win_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router.cc View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative/declarative_rule.h View 1 chunk +0 lines, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/browser/load_monitoring_extension_host_queue_unittest.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M ios/public/provider/chrome/browser/browser_state/chrome_browser_state_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_observer_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ipc/ipc_message_attachment_set.h View 1 chunk +0 lines, -1 line 0 comments Download
M mandoline/ui/desktop_ui/browser_manager.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M media/base/bind_to_current_loop.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/capture/video/linux/v4l2_capture_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/midi/usb_midi_device_factory_android.h View 1 chunk +0 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/runner/context.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/dns/mdns_client.h View 1 chunk +3 lines, -0 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/libaddressinput/chromium/chrome_metadata_source.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/android/forwarder2/host_forwarder_main.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/compositor/scoped_layer_animation_settings.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/libgestures_glue/gesture_feedback.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/events/ozone/evdev/touch_event_converter_evdev_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ui/message_center/message_center_impl.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/ozone/platform/drm/gpu/drm_device.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
Lei Zhang
I touched scoped_vector.h and the everything recompiled. :\ All the {+1, -1, +3, -3}s should ...
5 years, 4 months ago (2015-08-21 01:30:24 UTC) #2
brettw
rs lgtm
5 years, 4 months ago (2015-08-21 05:10:22 UTC) #3
Lei Zhang
TBR keybuk@ for device/bluetooth.
5 years, 4 months ago (2015-08-21 05:18:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307643003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307643003/20001
5 years, 4 months ago (2015-08-21 05:20:06 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/96610)
5 years, 4 months ago (2015-08-21 07:07:07 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307643003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307643003/40001
5 years, 4 months ago (2015-08-21 23:57:21 UTC) #14
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 4 months ago (2015-08-22 00:05:19 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-22 00:06:34 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/7790a3535f2a81a03685eca31a32cf69ae0c114f
Cr-Commit-Position: refs/heads/master@{#344925}

Powered by Google App Engine
This is Rietveld 408576698