Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(146)

Unified Diff: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h

Issue 1307533002: [Mac] Enable MacViews bookmark bubble behind --enable-mac-views-dialogs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@modal
Patch Set: Rebase atop https://codereview.chromium.org/1309583002/ Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
diff --git a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
index 51892ab0c766cc867657fa181d2ba99982538be7..9f35f6c6b72c866fea4bd1a1ffcc67685ba699f2 100644
--- a/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
+++ b/chrome/browser/ui/views/bookmarks/bookmark_bubble_view.h
@@ -17,9 +17,12 @@
#include "ui/views/controls/combobox/combobox_listener.h"
#include "url/gurl.h"
-class BookmarkBubbleViewObserver;
class Profile;
+namespace bookmarks {
+class BookmarkBubbleObserver;
+}
+
namespace views {
class LabelButton;
class Textfield;
@@ -33,8 +36,12 @@ class BookmarkBubbleView : public views::BubbleDelegateView,
public views::ButtonListener,
public views::ComboboxListener {
public:
+ // If |anchor_view| is null, |anchor_rect| is used to anchor the bubble and
+ // |parent_window| is used to ensure the bubble closes if the parent closes.
static void ShowBubble(views::View* anchor_view,
- BookmarkBubbleViewObserver* observer,
+ const gfx::Rect& anchor_rect,
+ gfx::NativeView parent_window,
+ bookmarks::BookmarkBubbleObserver* observer,
scoped_ptr<BookmarkBubbleDelegate> delegate,
Profile* profile,
const GURL& url,
@@ -65,7 +72,7 @@ class BookmarkBubbleView : public views::BubbleDelegateView,
// Creates a BookmarkBubbleView.
BookmarkBubbleView(views::View* anchor_view,
- BookmarkBubbleViewObserver* observer,
+ bookmarks::BookmarkBubbleObserver* observer,
scoped_ptr<BookmarkBubbleDelegate> delegate,
Profile* profile,
const GURL& url,
@@ -97,7 +104,7 @@ class BookmarkBubbleView : public views::BubbleDelegateView,
static BookmarkBubbleView* bookmark_bubble_;
// Our observer, to notify when the bubble shows or hides.
- BookmarkBubbleViewObserver* observer_;
+ bookmarks::BookmarkBubbleObserver* observer_;
// Delegate, to handle clicks on the sign in link.
scoped_ptr<BookmarkBubbleDelegate> delegate_;
« no previous file with comments | « chrome/browser/ui/views/bookmarks/bookmark_bar_view.h ('k') | chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698