Issue 130753004: Move isNameCacheValid member from LiveNodeListBase to HTMLCollection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 130753004: Move isNameCacheValid member from LiveNodeListBase to HTMLCollection (Closed)

Created:
6 years, 11 months ago by Inactive

Modified:
6 years, 11 months ago

Reviewers:
esprehn, eseidel

CC:
blink-reviews, dglazkov+blink, sof, eae+blinkwatch, adamk+blink_chromium.org, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Move isNameCacheValid member from LiveNodeListBase to HTMLCollection The isNameCacheValid member is only useful to HTMLCollection (not LiveNodeList), so move it and its corresponding getter / setter to the HTMLCollection class. There is no reason anymore to keep this member in the LiveNodeListBase class. R=eseidel, esprehn BUG=None Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165248

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -8 lines)			Patch
M	Source/core/dom/LiveNodeList.h	View	3 chunks	+1 line, -7 lines	0 comments	Download
M	Source/core/dom/LiveNodeList.cpp	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	Source/core/html/HTMLCollection.h	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLCollection.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/130753004/1

6 years, 11 months ago (2014-01-16 20:39:28 UTC) #4

Message was sent while issue was closed.

Change committed as 165248

Expand Messages | Collapse Messages