Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 130753003: Implement nacl_irt_filename for non-sfi mode. (Closed)

Created:
6 years, 11 months ago by hidehiko
Modified:
6 years, 1 month ago
Reviewers:
Mark Seaborn
CC:
chromium-reviews, hamaji
Visibility:
Public.

Description

Implement nacl_irt_filename for non-sfi mode. This CL implements nacl_irt_filename for non-sfi mode. Note that, in order to open a file, currently we need to set --no-sandbox flag, otherwise EPERM will be returned. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3734 TEST=Tried to call a newly added function from plugin via AT_SYSINFO.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -0 lines) Patch
M components/nacl.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A components/nacl/loader/nonsfi/irt_filename.cc View 1 chunk +82 lines, -0 lines 0 comments Download
M components/nacl/loader/nonsfi/irt_interfaces.h View 1 chunk +1 line, -0 lines 0 comments Download
M components/nacl/loader/nonsfi/irt_interfaces.cc View 1 chunk +1 line, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
hidehiko
Could you take a look? This CL is based on https://codereview.chromium.org/131133002, which is also based ...
6 years, 11 months ago (2014-01-09 14:13:06 UTC) #1
Mark Seaborn
https://codereview.chromium.org/130753003/diff/1/components/nacl/loader/nonsfi/irt_interfaces.cc File components/nacl/loader/nonsfi/irt_interfaces.cc (right): https://codereview.chromium.org/130753003/diff/1/components/nacl/loader/nonsfi/irt_interfaces.cc#newcode27 components/nacl/loader/nonsfi/irt_interfaces.cc:27: NACL_INTERFACE_TABLE(NACL_IRT_FILENAME_v0_1, kIrtFileName), This should be IRT_DEV_FILENAME. IRT_FILENAME is not ...
6 years, 11 months ago (2014-01-10 13:41:09 UTC) #2
hidehiko
https://codereview.chromium.org/130753003/diff/1/components/nacl/loader/nonsfi/irt_interfaces.cc File components/nacl/loader/nonsfi/irt_interfaces.cc (right): https://codereview.chromium.org/130753003/diff/1/components/nacl/loader/nonsfi/irt_interfaces.cc#newcode27 components/nacl/loader/nonsfi/irt_interfaces.cc:27: NACL_INTERFACE_TABLE(NACL_IRT_FILENAME_v0_1, kIrtFileName), On 2014/01/10 13:41:09, Mark Seaborn wrote: > ...
6 years, 11 months ago (2014-01-15 04:00:21 UTC) #3
hidehiko
6 years, 1 month ago (2014-10-29 09:34:38 UTC) #4
On 2014/01/15 04:00:21, hidehiko wrote:
>
https://codereview.chromium.org/130753003/diff/1/components/nacl/loader/nonsf...
> File components/nacl/loader/nonsfi/irt_interfaces.cc (right):
> 
>
https://codereview.chromium.org/130753003/diff/1/components/nacl/loader/nonsf...
> components/nacl/loader/nonsfi/irt_interfaces.cc:27:
> NACL_INTERFACE_TABLE(NACL_IRT_FILENAME_v0_1, kIrtFileName),
> On 2014/01/10 13:41:09, Mark Seaborn wrote:
> > This should be IRT_DEV_FILENAME.  IRT_FILENAME is not supported in the
> browser,
> > and we only have it queryable in existing ABIs for compatibility.  New ABIs
> > should not return it -- PNaCl doesn't.
> > 
> > So, if you want to add this, it should be behind a flag (as we discussed in
> > e-mail before).  But putting this behind a flag adds enough complexity that
I
> > would want to have a test for that.  So can we put this change on hold until
> > PPAPI works under Bare Metal Mode and we have enabled tests for it on the
> bots?
> 
> I see. I misunderstood. Let's keep this suspended for a while.

I think it's ok to close this CL.

Powered by Google App Engine
This is Rietveld 408576698