Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 130753002: Move DriveAppRegistry from c/b/chromeos/drive to c/b/drive. (Closed)

Created:
6 years, 11 months ago by kinaba
Modified:
6 years, 11 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tfarina, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move DriveAppRegistry from c/b/chromeos/drive to c/b/drive. for using the class in other platforms outside Chrome OS. BUG=312566 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243894

Patch Set 1 #

Patch Set 2 : Fix for Windows compilation #

Total comments: 2

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -447 lines) Patch
D chrome/browser/chromeos/drive/drive_app_registry.h View 1 chunk +0 lines, -114 lines 0 comments Download
D chrome/browser/chromeos/drive/drive_app_registry.cc View 1 chunk +0 lines, -180 lines 0 comments Download
D chrome/browser/chromeos/drive/drive_app_registry_unittest.cc View 1 chunk +0 lines, -140 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_integration_service.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_drive.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks.cc View 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/file_tasks_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/drive/drive_app_registry.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/drive/drive_app_registry.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
A + chrome/browser/drive/drive_app_registry_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
kinaba
6 years, 11 months ago (2014-01-09 04:37:31 UTC) #1
hashimoto
lgtm
6 years, 11 months ago (2014-01-09 04:46:11 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/130753002/1
6 years, 11 months ago (2014-01-09 04:52:38 UTC) #3
commit-bot: I haz the power
Failed to trigger a try job on linux_chromeos HTTP Error 400: Bad Request
6 years, 11 months ago (2014-01-09 05:18:20 UTC) #4
kinaba
Made one fix for string type mismatch on Windows. Could you take another look?
6 years, 11 months ago (2014-01-09 05:18:33 UTC) #5
hashimoto
https://codereview.chromium.org/130753002/diff/90003/chrome/browser/drive/drive_app_registry.cc File chrome/browser/drive/drive_app_registry.cc (right): https://codereview.chromium.org/130753002/diff/90003/chrome/browser/drive/drive_app_registry.cc#newcode78 chrome/browser/drive/drive_app_registry.cc:78: const base::FilePath::StringType without_dot = |without_dot| shouldn't be a std::string?
6 years, 11 months ago (2014-01-09 05:30:14 UTC) #6
kinaba
https://codereview.chromium.org/130753002/diff/90003/chrome/browser/drive/drive_app_registry.cc File chrome/browser/drive/drive_app_registry.cc (right): https://codereview.chromium.org/130753002/diff/90003/chrome/browser/drive/drive_app_registry.cc#newcode78 chrome/browser/drive/drive_app_registry.cc:78: const base::FilePath::StringType without_dot = On 2014/01/09 05:30:14, hashimoto wrote: ...
6 years, 11 months ago (2014-01-09 05:39:55 UTC) #7
hashimoto
lgtm
6 years, 11 months ago (2014-01-09 05:41:01 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/130753002/250001
6 years, 11 months ago (2014-01-09 05:42:56 UTC) #9
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 14:21:06 UTC) #10
Message was sent while issue was closed. 
Change committed as 243894

Powered by Google App Engine
This is Rietveld 408576698