Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1135)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307483002: Add USBConnectionEvent to webusb module. (Closed)

Created:
5 years, 4 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 4 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@usb_events
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add USBConnectionEvent to webusb module. This is the object passed to onconnected and ondisconnected event handlers connected to navigator.usb. BUG=492204 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200935

Patch Set 1 #

Patch Set 2 : Add generated sources to modules.gypi. #

Patch Set 3 : Update LayoutTests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -2 lines) Patch
M LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M Source/modules/modules.gypi View 1 2 4 chunks +6 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConnectionEvent.h View 1 chunk +35 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConnectionEvent.cpp View 1 chunk +43 lines, -0 lines 0 comments Download
A Source/modules/webusb/USBConnectionEvent.idl View 1 chunk +12 lines, -0 lines 0 comments Download
A + Source/modules/webusb/USBConnectionEventInit.idl View 1 2 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Reilly Grant (use Gerrit)
I think I'm starting to get the hang of this. Please take a look.
5 years, 4 months ago (2015-08-19 23:21:15 UTC) #3
Ken Rockot(use gerrit already)
lgtm
5 years, 4 months ago (2015-08-19 23:57:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307483002/40001
5 years, 4 months ago (2015-08-20 17:34:07 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/101785)
5 years, 4 months ago (2015-08-20 18:21:06 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307483002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307483002/60001
5 years, 4 months ago (2015-08-20 19:31:34 UTC) #11
commit-bot: I haz the power
5 years, 4 months ago (2015-08-20 22:42:42 UTC) #12
Message was sent while issue was closed. 
Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200935

Powered by Google App Engine
This is Rietveld 408576698