Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Issue 1307463003: Fix compile error with Windows clang. (Closed)

Created:
5 years, 4 months ago by Will Harris
Modified:
5 years, 4 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com, Yoshisato Yanagisawa
Visibility:
Public.

Description

Fix compile error with Windows clang. This change fixes the following errors shown during compile with Windows clang: error: cannot pass non-trivial object of type 'ATL::CComBSTR' to variadic function; expected type from format string was 'wchar_t *' [-Wnon-pod-varargs] Original CL: https://codereview.chromium.org/1252913009/ BUG=https://code.google.com/p/google-breakpad/issues/detail?id=662 Committed: https://code.google.com/p/google-breakpad/source/detail?r=1494

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -4 lines) Patch
M src/common/windows/pdb_source_line_writer.cc View 5 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 3 (1 generated)
Will Harris
committing on behalf of yyanagisawa@chromium.org
5 years, 4 months ago (2015-08-19 22:03:03 UTC) #2
Will Harris
5 years, 4 months ago (2015-08-19 22:28:21 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as r1494 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698