Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 13074002: Add string for 'Unknown device' for use on history page. (Closed)

Created:
7 years, 9 months ago by Patrick Dubroy
Modified:
7 years, 9 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Visibility:
Public.

Description

Add string for 'Unknown device' for use on history page. TBR=estade@chromium.org BUG=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Patrick Dubroy
Committed patchset #1 manually as r190507 (presubmit successful).
7 years, 9 months ago (2013-03-25 22:58:02 UTC) #1
Evan Stade
7 years, 9 months ago (2013-03-25 23:04:41 UTC) #2
lgtm


-- Evan Stade


On Mon, Mar 25, 2013 at 3:58 PM, <dubroy@chromium.org> wrote:

> Reviewers: Evan Stade,
>
> Message:
> Committed patchset #1 manually as r190507 (presubmit successful).
>
> Description:
> Add string for 'Unknown device' for use on history page.
>
> TBR=estade@chromium.org
> BUG=None
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=190507<https://src.chromium.org/viewvc/chrome?view=rev&revision=190507>
>
> Please review this at
https://codereview.chromium.**org/13074002/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/app/generated_**resources.grd
>
>
> Index: chrome/app/generated_**resources.grd
> diff --git a/chrome/app/generated_**resources.grd b/chrome/app/generated_*
> *resources.grd
> index eda8fd88a18da7e9452e0e2589aa28**3e87fc6403..**
> 94f873bc58999b250ae6373d64c40f**c5e1d2a205 100644
> --- a/chrome/app/generated_**resources.grd
> +++ b/chrome/app/generated_**resources.grd
> @@ -482,6 +482,9 @@ Psst! Incognito mode <ph
name="SHORTCUT_KEY">$1<ex>(**Ctrl+Shift+N)</ex></ph>
> may
>        <message name="IDS_HISTORY_NO_RESPONSE_**FROM_SERVER" desc="The
> notification at the top of the history page indicating that there was no
> response received from the history server.">
>          Showing history from this device. <ph name="BEGIN_LINK">&lt;a
>
href="http://support.google.**com/chrome/bin/answer.py?**answer=95589<http://support.google.com/chrome/bin/answer.py?answer=95589>
> "&amp;hl=[**GRITLANGCODE]"&gt;</ph>Learn more<ph
> name="END_LINK">&lt;/a&gt;<ex>**&lt;/a&gt;</ex></ph>
>        </message>
> +      <message name="IDS_HISTORY_UNKNOWN_**DEVICE" desc="On the dropdown
> menu for a history entry, the text that is shown instead of a device name,
> when the device name is not known.">
> +        Unknown device
> +      </message>
>
>        <!-- Generic terms -->
>        <message name="IDS_OK" desc="Used for OK on buttons">
>
>
>

Powered by Google App Engine
This is Rietveld 408576698