[DevTools] Promisify RemoteObject methods

Source/devtools/front_end/sdk/RemoteObject.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 99 matching lines @@
         {
             callback({
                 properties: properties,
                 internalProperties: internalProperties
             });
         }
     },
 
     /**
      * @param {boolean} accessorPropertiesOnly
-     * @param {function(?Array.<!WebInspector.RemoteObjectProperty>, ?Array.<!WebInspector.RemoteObjectProperty>)} callback
+     * @param {function(?Array<!WebInspector.RemoteObjectProperty>, ?Array<!WebInspector.RemoteObjectProperty>)} callback
      */
     getAllProperties: function(accessorPropertiesOnly, callback)
     {
         throw "Not implemented";
     },
 
     /**
+     * @param {boolean} accessorPropertiesOnly
+     * @return {!Promise<!{properties: ?Array<!WebInspector.RemoteObjectProperty>, internalProperties: ?Array<!WebInspector.RemoteObjectProperty>}>}
+     */
+    getAllPropertiesPromise: function(accessorPropertiesOnly)
+    {
+        return new Promise(promiseConstructor.bind(this));
+
+        /**
+         * @param {function(!{properties: ?Array<!WebInspector.RemoteObjectProperty>, internalProperties: ?Array.<!WebInspector.RemoteObjectProperty>})} success
+         * @this {WebInspector.RemoteObject}
+         */
+        function promiseConstructor(success)
+        {
+            this.getAllProperties(accessorPropertiesOnly, getAllPropertiesCallback.bind(null, success));
+        }
+
+        /**
+         * @param {function(!{properties: ?Array<!WebInspector.RemoteObjectProperty>, internalProperties: ?Array<!WebInspector.RemoteObjectProperty>})} callback
+         * @param {?Array<!WebInspector.RemoteObjectProperty>} properties
+         * @param {?Array<!WebInspector.RemoteObjectProperty>} internalProperties
+         */
+        function getAllPropertiesCallback(callback, properties, internalProperties)
+        {
+            callback({
+                properties: properties,
+                internalProperties: internalProperties
+            });
+        }
+    },
+
+    /**
      * @return {!Promise<?Array<!WebInspector.EventListener>>}
      */
     eventListeners: function()
     {
         throw "Not implemented";
     },
 
     /**
      * @param {!RuntimeAgent.CallArgument} name
      * @param {function(string=)} callback
@@ skipping 40 matching lines @@
         {
             callback({
                 object: object,
                 wasThrown: wasThrown
             });
         }
     },
 
     /**
      * @param {function(this:Object)} functionDeclaration
-     * @param {!Array.<!RuntimeAgent.CallArgument>|undefined} args
+     * @param {!Array<!RuntimeAgent.CallArgument>|undefined} args
      * @param {function(*)} callback
      */
     callFunctionJSON: function(functionDeclaration, args, callback)
     {
         throw "Not implemented";
     },
 
     /**
+     * @param {function(this:Object)} functionDeclaration
+     * @param {!Array<!RuntimeAgent.CallArgument>|undefined} args
+     * @return {!Promise<*>}
+     */
+    callFunctionJSONPromise: function(functionDeclaration, args)
+    {
+        return new Promise(promiseConstructor.bind(this));
+
+        /**
+         * @this {WebInspector.RemoteObject}
+         */
+         function promiseConstructor(success)
+         {
+            this.callFunctionJSON(functionDeclaration, args, success);
+         }
+    },
+
+    /**
      * @return {!WebInspector.Target}
      */
     target: function()
     {
         throw new Error("Target-less object");
     },
 
     /**
      * @return {?WebInspector.DebuggerModel}
      */
@@ skipping 12 matching lines @@
 
     /**
      * @param {function(?WebInspector.DebuggerModel.FunctionDetails)} callback
      */
     functionDetails: function(callback)
     {
         callback(null);
     },
 
     /**
+     * @return {!Promise<?WebInspector.DebuggerModel.FunctionDetails>}
+     */
+    functionDetailsPromise: function()
+    {
+        return new Promise(promiseConstructor.bind(this));
+
+        /**
+         * @param {function(?WebInspector.DebuggerModel.FunctionDetails)} success
+         * @this {WebInspector.RemoteObject}
+         */
+        function promiseConstructor(success)
+        {
+            this.functionDetails(success);
+        }
+    },
+
+    /**
      * @param {function(?WebInspector.DebuggerModel.GeneratorObjectDetails)} callback
      */
     generatorObjectDetails: function(callback)
     {
         callback(null);
     },
 
     /**
-     * @param {function(?Array.<!DebuggerAgent.CollectionEntry>)} callback
+     * @return {!Promise<?WebInspector.DebuggerModel.GeneratorObjectDetails>}
+     */
+    generatorObjectDetailsPromise: function()

[pfeldman, 2015/08/25 00:55:24]

Do you need all of these?

+    {
+        return new Promise(promiseConstructor.bind(this));
+
+        /**
+         * @param {function(?WebInspector.DebuggerModel.GeneratorObjectDetails)} success
+         * @this {WebInspector.RemoteObject}
+         */
+        function promiseConstructor(success)
+        {
+            this.generatorObjectDetails(success);
+        }
+    },
+
+    /**
+     * @param {function(?Array<!DebuggerAgent.CollectionEntry>)} callback
      */
     collectionEntries: function(callback)
     {
         callback(null);
+    },
+
+    /**
+     * @return {!Promise<?Array<!DebuggerAgent.CollectionEntry>>}
+     */
+    collectionEntriesPromise: function()
+    {
+        return new Promise(promiseConstructor.bind(this));
+
+        /**
+         * @param {function(?Array<!DebuggerAgent.CollectionEntry>)} success
+         * @this {WebInspector.RemoteObject}
+         */
+        function promiseConstructor(success)
+        {
+            this.collectionEntries(success);
+        }
     }
 }
 
 /**
  * @param {*} value
  * @return {!WebInspector.RemoteObject}
  */
 WebInspector.RemoteObject.fromLocalObject = function(value)
 {
     return new WebInspector.LocalJSONObject(value);
@@ skipping 1033 matching lines @@
     {
         if (!this._cachedDescription) {
             var children = this._children();
             this._cachedDescription = "{" + this._formatValue(children[0].value) + " => " + this._formatValue(children[1].value) + "}";
         }
         return this._cachedDescription;
     },
 
     __proto__: WebInspector.LocalJSONObject.prototype
 }