Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307383002: [DevTools] Promisify RemoteObject methods (Closed)

Created:
5 years, 4 months ago by kozy
Modified:
5 years, 4 months ago
Reviewers:
pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : Removed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -3 lines) Patch
M Source/devtools/front_end/sdk/RemoteObject.js View 1 6 chunks +69 lines, -3 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
kozy
Pavel, please take a look.
5 years, 4 months ago (2015-08-25 00:47:07 UTC) #1
pfeldman
lgtm https://codereview.chromium.org/1307383002/diff/1/Source/devtools/front_end/sdk/RemoteObject.js File Source/devtools/front_end/sdk/RemoteObject.js (right): https://codereview.chromium.org/1307383002/diff/1/Source/devtools/front_end/sdk/RemoteObject.js#newcode305 Source/devtools/front_end/sdk/RemoteObject.js:305: generatorObjectDetailsPromise: function() Do you need all of these?
5 years, 4 months ago (2015-08-25 00:55:24 UTC) #2
kozy
On 2015/08/25 00:55:24, pfeldman wrote: > lgtm > > https://codereview.chromium.org/1307383002/diff/1/Source/devtools/front_end/sdk/RemoteObject.js > File Source/devtools/front_end/sdk/RemoteObject.js (right): > ...
5 years, 4 months ago (2015-08-25 01:10:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307383002/20001
5 years, 4 months ago (2015-08-25 01:11:02 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/103503)
5 years, 4 months ago (2015-08-25 02:14:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307383002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307383002/20001
5 years, 4 months ago (2015-08-25 17:27:15 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 18:08:36 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201143

Powered by Google App Engine
This is Rietveld 408576698