Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(170)

Issue 1307363007: Revert of [sqlite] Respect the gyp and gn component switch. (Closed)

Created:
5 years, 3 months ago by Scott Hess - ex-Googler
Modified:
5 years, 3 months ago
Reviewers:
michaeln, Nico
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [sqlite] Respect the gyp and gn component switch. (patchset #2 id:20001 of https://codereview.chromium.org/1325513002/ ) Reason for revert: ARRGH! win8_chromium_gn_dgb is still broken. Original issue's description: > [sqlite] Respect the gyp and gn component switch. > > SQLITE_API is the existing mechanism SQLite provides, and is used in > preference to inventing a new SQLITE_EXPORT symbol (like > sql/sql_export.h and other examples). > > CoreServices.framework is necessary on OSX because of the Time Machine > patch. > > Remove sql/proxy.{h,cc}, which was necessary to work around SQLite > linking statically into both component shlibs and unit test executables. > > [Relanding https://codereview.chromium.org/1322463002/ ] > > BUG=489444 > TBR=michaeln@chromium.org, thakis@chromium.org > > Committed: https://crrev.com/02ce712af589a5b722ebbf5c2fffb3e0d4849963 > Cr-Commit-Position: refs/heads/master@{#346212} TBR=michaeln@chromium.org,thakis@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=489444 Committed: https://crrev.com/e4f267ed41eeb5535714b072981c5647f51c5947 Cr-Commit-Position: refs/heads/master@{#346213}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -32 lines) Patch
M sql/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M sql/connection_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
A sql/proxy.h View 1 chunk +39 lines, -0 lines 0 comments Download
A sql/proxy.cc View 1 chunk +28 lines, -0 lines 0 comments Download
M sql/sql.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/sqlite/BUILD.gn View 3 chunks +2 lines, -15 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 3 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Scott Hess - ex-Googler
Created Revert of [sqlite] Respect the gyp and gn component switch.
5 years, 3 months ago (2015-08-28 19:52:59 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307363007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307363007/1
5 years, 3 months ago (2015-08-28 19:53:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-08-28 19:54:01 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-08-28 19:54:48 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4f267ed41eeb5535714b072981c5647f51c5947
Cr-Commit-Position: refs/heads/master@{#346213}

Powered by Google App Engine
This is Rietveld 408576698