Source/core/inspector/PageDebuggerAgent.cpp - Issue 1307363006: DevTools: move instrumentation of v8 calls into V8ScriptRunner

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/inspector/PageDebuggerAgent.cpp

Issue 1307363006: DevTools: move instrumentation of v8 calls into V8ScriptRunner (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Merged willCall and willEvaluate on V8DebuggerAgent Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.idl ('k') | Source/core/inspector/V8DebuggerAgent.h » ('j') | Source/core/inspector/V8DebuggerAgent.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/inspector/PageDebuggerAgent.cpp

diff --git a/Source/core/inspector/PageDebuggerAgent.cpp b/Source/core/inspector/PageDebuggerAgent.cpp

index 8f22a25f7ef14cdf4193c61649624a3e9ac0d0ee..cb70c5c94c781a7f6303dcd023f13a59ec1d90f7 100644

--- a/Source/core/inspector/PageDebuggerAgent.cpp

+++ b/Source/core/inspector/PageDebuggerAgent.cpp

@@ -185,15 +185,11 @@ void PageDebuggerAgent::runScript(ErrorString* errorString, const ScriptId& scri

String sourceURL = m_compiledScriptURLs.take(scriptId);

LocalFrame* frame = toDocument(executionContext)->frame();

TRACE_EVENT1("devtools.timeline", "EvaluateScript", "data", InspectorEvaluateScriptEvent::data(frame, sourceURL, TextPosition::minimumPosition().m_line.oneBasedInt()));

- InspectorInstrumentationCookie cookie;

- if (frame)

- cookie = InspectorInstrumentation::willEvaluateScript(frame);

+ InspectorInstrumentation::willEvaluateScript(executionContext);

dgozman 2015/08/29 00:04:39 Remove this.

yurys 2015/08/29 00:14:24 Done.

RefPtrWillBeRawPtr<LocalFrame> protect(frame);

InspectorDebuggerAgent::runScript(errorString, scriptId, executionContextId, objectGroup, doNotPauseOnExceptionsAndMuteConsole, result, exceptionDetails);

- if (frame)

- InspectorInstrumentation::didEvaluateScript(cookie);

TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "UpdateCounters", TRACE_EVENT_SCOPE_THREAD, "data", InspectorUpdateCountersEvent::data());

}

« no previous file with comments | « Source/core/inspector/InspectorInstrumentation.idl ('k') | Source/core/inspector/V8DebuggerAgent.h » ('j') | Source/core/inspector/V8DebuggerAgent.cpp » ('J')