Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1307363006: DevTools: move instrumentation of v8 calls into V8ScriptRunner (Closed)

Created:
5 years, 3 months ago by yurys
Modified:
5 years, 3 months ago
Reviewers:
kozy, dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, pfeldman+blink_chromium.org, vivekg_samsung, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vivekg, apavlov+blink_chromium.org, Inactive, devtools-reviews_chromium.org, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: move instrumentation of v8 calls into V8ScriptRunner All function calls/script evaluations in Blink now go through V8ScriptRunner moving InspectorInstrumentation hooks in there guarantees that all call sites are instrumented. I left InspectorInstrumentation::willEvaluateScript but it is now only used by DOMDebugger to support "pause on first statement" breakpoints. If I moved this call into V8ScriptRunner::runCompiledScript we would start pausing on all console evaluations including those made for auto-complete. This can be addressed separately. BUG=525306 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201443

Patch Set 1 #

Patch Set 2 #

Patch Set 3 : Merged willCall and willEvaluate on V8DebuggerAgent #

Total comments: 4

Patch Set 4 : addressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -69 lines) Patch
M Source/bindings/core/v8/ScriptController.cpp View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.cpp View 1 2 3 3 chunks +5 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/inspector/InjectedScript.cpp View 1 3 chunks +5 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.cpp View 1 2 3 1 chunk +4 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 2 chunks +4 lines, -7 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 3 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/inspector/V8DebuggerAgent.h View 1 2 3 1 chunk +2 lines, -4 lines 0 comments Download
M Source/core/inspector/V8DebuggerAgent.cpp View 1 2 3 2 chunks +2 lines, -13 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
yurys
5 years, 3 months ago (2015-08-28 21:29:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307363006/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307363006/20001
5 years, 3 months ago (2015-08-28 21:46:06 UTC) #4
yurys
PTAL
5 years, 3 months ago (2015-08-28 23:11:43 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307363006/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307363006/40001
5 years, 3 months ago (2015-08-28 23:12:24 UTC) #7
dgozman
lgtm https://codereview.chromium.org/1307363006/diff/40001/Source/core/inspector/PageDebuggerAgent.cpp File Source/core/inspector/PageDebuggerAgent.cpp (right): https://codereview.chromium.org/1307363006/diff/40001/Source/core/inspector/PageDebuggerAgent.cpp#newcode188 Source/core/inspector/PageDebuggerAgent.cpp:188: InspectorInstrumentation::willEvaluateScript(executionContext); Remove this. https://codereview.chromium.org/1307363006/diff/40001/Source/core/inspector/V8DebuggerAgent.cpp File Source/core/inspector/V8DebuggerAgent.cpp (right): https://codereview.chromium.org/1307363006/diff/40001/Source/core/inspector/V8DebuggerAgent.cpp#newcode1368 ...
5 years, 3 months ago (2015-08-29 00:04:40 UTC) #8
yurys
https://codereview.chromium.org/1307363006/diff/40001/Source/core/inspector/PageDebuggerAgent.cpp File Source/core/inspector/PageDebuggerAgent.cpp (right): https://codereview.chromium.org/1307363006/diff/40001/Source/core/inspector/PageDebuggerAgent.cpp#newcode188 Source/core/inspector/PageDebuggerAgent.cpp:188: InspectorInstrumentation::willEvaluateScript(executionContext); On 2015/08/29 00:04:39, dgozman wrote: > Remove this. ...
5 years, 3 months ago (2015-08-29 00:14:24 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307363006/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307363006/60001
5 years, 3 months ago (2015-08-29 00:14:47 UTC) #12
commit-bot: I haz the power
5 years, 3 months ago (2015-08-29 01:44:09 UTC) #13
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201443

Powered by Google App Engine
This is Rietveld 408576698