Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1307333002: Add alerting for CTFE V2. (Closed)

Created:
5 years, 4 months ago by dogben
Modified:
5 years, 3 months ago
Reviewers:
jcgregorio, rmistry
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/buildbot@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add alerting for CTFE V2. Currently configured for ct-staging for testing. We can change that to the non-staging instance once that is set up. Configure prober to hit all HTML pages and all "get" JSON endpoints. Add some specific checks as new body testers. Also check that there is at least one valid chromium build and at least one valid SKP repository. Refactor functions that get the oldest pending task. Create a new package "task_types" and move supportedTasks there (as a function to allow modifying the returned tasks). Add metrics collection as a goroutine in CTFE. Report stats on pending tasks. Set the graphite_server flag in ctfe.service. BUG=skia:4074 Committed: https://skia.googlesource.com/buildbot/+/b82e9e56fcd5a62091bda7c00bd3be8d7e762c8b

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Reformat #

Total comments: 1

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+702 lines, -62 lines) Patch
M alertserver/alerts.cfg View 2 chunks +324 lines, -0 lines 0 comments Download
M ct/go/ctfe/main.go View 1 6 chunks +40 lines, -11 lines 0 comments Download
M ct/go/ctfe/pending_tasks/pending_tasks.go View 1 4 chunks +33 lines, -45 lines 0 comments Download
A ct/go/ctfe/task_types/task_types.go View 1 chunk +26 lines, -0 lines 0 comments Download
M ct/sys/ctfe.service View 1 chunk +5 lines, -1 line 0 comments Download
M go/common/common.go View 1 chunk +1 line, -1 line 0 comments Download
M prober/go/prober/main.go View 2 chunks +79 lines, -4 lines 0 comments Download
M prober/probers.json View 1 2 1 chunk +194 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
dogben
5 years, 3 months ago (2015-08-26 13:39:17 UTC) #3
jcgregorio
LGTM modulo the nit with wrapping lines in Go. https://codereview.chromium.org/1307333002/diff/20001/ct/go/ctfe/main.go File ct/go/ctfe/main.go (right): https://codereview.chromium.org/1307333002/diff/20001/ct/go/ctfe/main.go#newcode118 ct/go/ctfe/main.go:118: ...
5 years, 3 months ago (2015-08-26 14:40:45 UTC) #4
dogben
https://codereview.chromium.org/1307333002/diff/20001/ct/go/ctfe/main.go File ct/go/ctfe/main.go (right): https://codereview.chromium.org/1307333002/diff/20001/ct/go/ctfe/main.go#newcode118 ct/go/ctfe/main.go:118: pendingTasksGauge := metrics.GetOrRegisterGauge("num-pending-tasks", On 2015/08/26 14:40:44, jcgregorio wrote: > ...
5 years, 3 months ago (2015-08-26 15:24:01 UTC) #5
rmistry
lgtm https://codereview.chromium.org/1307333002/diff/40001/go/common/common.go File go/common/common.go (left): https://codereview.chromium.org/1307333002/diff/40001/go/common/common.go#oldcode59 go/common/common.go:59: glog.Warningf("No metrics server speicifed.") Thank you. This bothered ...
5 years, 3 months ago (2015-08-26 20:53:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307333002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307333002/40001
5 years, 3 months ago (2015-08-26 21:19:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Infra-PerCommit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/Infra-PerCommit-Trybot/builds/1197)
5 years, 3 months ago (2015-08-26 21:20:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1307333002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1307333002/60001
5 years, 3 months ago (2015-08-26 21:42:47 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-08-26 21:44:17 UTC) #15
Message was sent while issue was closed.
Committed patchset #3 (id:60001) as
https://skia.googlesource.com/buildbot/+/b82e9e56fcd5a62091bda7c00bd3be8d7e76...

Powered by Google App Engine
This is Rietveld 408576698